Skip to content

Manual: Change Language items sync to share. Fix minor sorting mistake #16780

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 31, 2014

Conversation

mdinger
Copy link
Contributor

@mdinger mdinger commented Aug 27, 2014

The Language item no_sync_bound in Marker types has been replaced with no_share_bound. This updates the manual and does a minor sorting fix.

Fixes #16414

cc @cmr

r?

@Kimundi
Copy link
Member

Kimundi commented Aug 27, 2014

Didn't Share get renamed to Sync, and not other way round?

@emberian
Copy link
Member

Feh, the language item still uses the old name.

@mdinger mdinger mentioned this pull request Aug 27, 2014
@mdinger
Copy link
Contributor Author

mdinger commented Aug 27, 2014

I didn't know.

cc @alexcrichton in case he has an opinion because it was his fix.

@alexcrichton
Copy link
Member

Share was renamed to Sync, not the other way around. All references should mention sync, not share

@emberian
Copy link
Member

The lang item still has the old name in libcore.

@mdinger
Copy link
Contributor Author

mdinger commented Aug 27, 2014

I can try changing the lang item but it'll take longer because I gotta make sure it builds.

@mdinger
Copy link
Contributor Author

mdinger commented Aug 28, 2014

I tried swapping the language items in this branch but it started throwing warnings (but no errors) in case it's of use to you guys. I don't intend to mess with it further because I'm not sure what the issue is and don't want to waste more time searching.

Here are my warnings:

/home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:168:5: 168:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:168     noshare: marker::NoSync,
                                                                 ^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:216:5: 216:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:216     noshare: marker::NoSync,
                                                                 ^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:90:5: 90:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:90     noshare: marker::NoSync,
                                                                 ^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:98:5: 98:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:98     noshare: marker::NoSync,
                                                                 ^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:380:5: 380:27 warning: code is never used: `marker`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:380     marker: marker::NoSync,
                                                                     ^~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:398:5: 398:27 warning: code is never used: `marker`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:398     marker: marker::NoSync,
                                                                     ^~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:407:5: 407:27 warning: code is never used: `marker`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:407     marker: marker::NoSync,
                                                                     ^~~~~~~~~~~~~~~~~~~~~~

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 31, 2014
@bors bors merged commit 48a2876 into rust-lang:master Aug 31, 2014
@mdinger mdinger deleted the marker_types branch January 2, 2015 20:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual: Give lists of items/attributes some type of order
5 participants