-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Manual: Change Language items
sync
to share
. Fix minor sorting mistake
#16780
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Didn't |
Feh, the language item still uses the old name. |
I didn't know. cc @alexcrichton in case he has an opinion because it was his fix. |
|
The lang item still has the old name in libcore. |
I can try changing the lang item but it'll take longer because I gotta make sure it builds. |
I tried swapping the language items in this branch but it started throwing warnings (but no errors) in case it's of use to you guys. I don't intend to mess with it further because I'm not sure what the issue is and don't want to waste more time searching. Here are my warnings: /home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:168:5: 168:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:168 noshare: marker::NoSync,
^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:216:5: 216:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libcore/cell.rs:216 noshare: marker::NoSync,
^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:90:5: 90:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:90 noshare: marker::NoSync,
^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:98:5: 98:28 warning: code is never used: `noshare`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/deque.rs:98 noshare: marker::NoSync,
^~~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:380:5: 380:27 warning: code is never used: `marker`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:380 marker: marker::NoSync,
^~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:398:5: 398:27 warning: code is never used: `marker`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:398 marker: marker::NoSync,
^~~~~~~~~~~~~~~~~~~~~~
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:407:5: 407:27 warning: code is never used: `marker`, #[warn(dead_code)] on by default
/home/mdinger/Programs/rust/rust_src/src/libsync/comm/mod.rs:407 marker: marker::NoSync,
^~~~~~~~~~~~~~~~~~~~~~ |
The Language item
no_sync_bound
in Marker types has been replaced withno_share_bound
. This updates the manual and does a minor sorting fix.Fixes #16414
cc @cmr
r?