Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Regression in curs-0.1.3, Rust 1.17 #40956

Closed
brson opened this issue Mar 31, 2017 · 4 comments
Closed

Regression in curs-0.1.3, Rust 1.17 #40956

brson opened this issue Mar 31, 2017 · 4 comments
Assignees
@alexcrichton
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@brson
Copy link
Contributor

brson commented Mar 31, 2017 

boom! testing curs-0.1.3 against nightly for nightly
boom! running: cargo +nightly build --frozen
boom! creating container for: cargo +nightly build --frozen
boom! running `docker create -v /home/ec2-user/cargobomb/./work/local/test-source/nightly/nightly:/source:ro -v /home/ec2-user/cargobomb/./work/local/cargo-home:/cargo-home:ro -v /home/ec2-user/cargobomb/./work/local/rustup-home:/rustup-home:ro -v /home/ec2-user/cargobomb/./work/local/target-dirs/nightly/nightly:/target:rw -e USER_ID=500 -e CMD=cargo +nightly build --frozen cargobomb`
blam! af7aa3bfb0cd952fd945ba979d3d1249ef29a145140a3d36af9485410134d205
boom! running `docker start -a af7aa3bfb0cd952fd945ba979d3d1249ef29a145140a3d36af9485410134d205`
kablam! error: unable to get packages from source
kablam! 
kablam! Caused by:
kablam!   failed to parse manifest at `/cargo-home/registry/src/github.heygears.com-1ecc6299db9ec823/url-0.5.5/Cargo.toml`
kablam! 
kablam! Caused by:
kablam!   could not parse input as TOML
kablam! 
kablam! Caused by:
kablam!   expected newline, found an identifier at line 14
boom! running `docker rm -f af7aa3bfb0cd952fd945ba979d3d1249ef29a145140a3d36af9485410134d205`
blam! af7aa3bfb0cd952fd945ba979d3d1249ef29a145140a3d36af9485410134d205

cc @alexcrichton
@brson brson added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Mar 31, 2017
@brson
Copy link
Contributor Author

brson commented Mar 31, 2017

cc @bitex-la

@brson brson changed the title Regression in curs-0.1.3, Rust 1.16 Regression in curs-0.1.3, Rust 1.17 Mar 31, 2017
@alexcrichton
Copy link
Member

This was caused in the TOML refactor in Cargo, the fallback support to support malformed Cargo.toml is likely broken.

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Apr 1, 2017
@alexcrichton
Update toml to fix a regression in backcompat
21dea9c 
Related to rust-lang/rust#40956
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Apr 1, 2017
@alexcrichton
Update toml to fix a regression in backcompat
536638d 
Related to rust-lang/rust#40956
@alexcrichton alexcrichton mentioned this issue Apr 1, 2017
Merged
bors added a commit to rust-lang/cargo that referenced this issue Apr 1, 2017
@bors
Auto merge of #3889 - alexcrichton:toml-fix, r=alexcrichton
35bf210 
Update toml to fix a regression in backcompat

Related to rust-lang/rust#40956
@alexcrichton alexcrichton mentioned this issue Apr 1, 2017
Merged
@alexcrichton
Copy link
Member

Fixes are sent to Cargo, I'll send PRs to rust-lang/rust when they're merged

bors added a commit to rust-lang/cargo that referenced this issue Apr 1, 2017
@bors
Auto merge of #3890 - alexcrichton:beta-next, r=alexcrichton
d8d0940 
[beta] Update toml to fix a regression in backcompat

Related to rust-lang/rust#40956
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 1, 2017
@alexcrichton
Update cargo submodule
8ad8ba6 
Pulls in a fix for rust-lang#40956
@alexcrichton alexcrichton mentioned this issue Apr 1, 2017
Merged
@brson brson added the P-high High priority label Apr 4, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#40996 - alexcrichton:update-cargo, r=alexcr…
bfe32ce 
…ichton

Update cargo submodule

Pulls in a fix for rust-lang#40956
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 6, 2017
@frewsxcv
Rollup merge of rust-lang#40996 - alexcrichton:update-cargo, r=alexcr…
f88b44f 
…ichton

Update cargo submodule

Pulls in a fix for rust-lang#40956
bors added a commit that referenced this issue Apr 6, 2017
@bors
Auto merge of #40996 - alexcrichton:update-cargo, r=alexcrichton
9e84bf8 
Update cargo submodule

Pulls in a fix for #40956
@alexcrichton
Copy link
Member

Submodules landed!

cuviper pushed a commit to cuviper/rayon that referenced this issue Apr 18, 2017
@bors
Auto merge of #40996 - alexcrichton:update-cargo, r=alexcrichton
2dac91c 
Update cargo submodule

Pulls in a fix for rust-lang/rust#40956
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alexcrichton alexcrichton

Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @brson