Skip to content

Tracking issue for -Z profile #42524

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
alexcrichton opened this issue Jun 8, 2017 · 11 comments
Closed

Tracking issue for -Z profile #42524

alexcrichton opened this issue Jun 8, 2017 · 11 comments
Labels
A-CLI Area: Command-line interface (CLI) to the compiler A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation.

Comments

@alexcrichton
Copy link
Member

This is intended to be a tracking issue for the profiling feature, built on the gcov-style support in LLVM first added in #38608 and later rebased in #42433.
@alexcrichton alexcrichton added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Jun 8, 2017
This was referenced Jun 8, 2017
Merged
Closed
@sophiajt sophiajt mentioned this issue Jun 8, 2017
Open
@kennytm kennytm mentioned this issue Jun 13, 2017
Closed
3 tasks
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jul 22, 2017
@alexcrichton alexcrichton mentioned this issue Aug 25, 2017
Closed
This was referenced Sep 18, 2017
Closed
Closed
@mssun mssun mentioned this issue Apr 24, 2018
Closed
@garious garious mentioned this issue May 7, 2018
Closed
This was referenced Jul 2, 2018
Closed
Closed
Closed
This was referenced Oct 3, 2018
Closed
Closed
@lu-zero lu-zero mentioned this issue Oct 15, 2018
Open
@Minoru Minoru mentioned this issue Sep 7, 2019
Closed
@Minoru Minoru mentioned this issue Oct 6, 2019
Closed
@Luni-4 Luni-4 mentioned this issue Nov 27, 2019
Merged
@steveklabnik
Copy link
Member

Triage: not aware of any major move to stabilize this.

@glandium
Copy link
Contributor

glandium commented Feb 7, 2020

Is it expected that this doesn't work with --release?

@mzabaluev mzabaluev mentioned this issue Jun 4, 2020
Closed
@tylerhawkes
Copy link

Is there a way to change the path that the tests output to? I want to use this on some code that is cross compiled and needs to run on a device that only has a few writable paths. I'm currently getting this to work by replacing /target/aarch64... with ./arget/aarch64... in the binary since we can't change the length of the string.

I've never worked on the compiler before, but an option for this would be very useful.

@jackh726 jackh726 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation. and removed T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Mar 17, 2022
@workingjubilee workingjubilee added the A-CLI Area: Command-line interface (CLI) to the compiler label Mar 5, 2023
@Zalathar Zalathar mentioned this issue Oct 17, 2024
Merged
@Zalathar Zalathar mentioned this issue Oct 17, 2024
Closed
3 tasks
@MajoraSans MajoraSans mentioned this issue Oct 21, 2024
Open
85 tasks
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#131829 - Zalathar:goodbye-zprofile, r=cheny…
11a09d4 
…ukang

Remove support for `-Zprofile` (gcov-style coverage instrumentation)

Tracking issue: rust-lang#42524

MCP: rust-lang/compiler-team#798

---

This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag.

(The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.)

Notably, the `-Zprofile` flag:
- Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful.
- Has no known maintainer.
- Has seen no push towards stabilization.
- Has at least one severe regression reported in 2022 that apparently remains unaddressed.
  - rust-lang#100125
- Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO.
- Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.
jieyouxu added a commit to jieyouxu/rust that referenced this issue Nov 1, 2024
@jieyouxu
Rollup merge of rust-lang#131829 - Zalathar:goodbye-zprofile, r=cheny…
968e7aa 
…ukang

Remove support for `-Zprofile` (gcov-style coverage instrumentation)

Tracking issue: rust-lang#42524

MCP: rust-lang/compiler-team#798

---

This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag.

(The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.)

Notably, the `-Zprofile` flag:
- Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful.
- Has no known maintainer.
- Has seen no push towards stabilization.
- Has at least one severe regression reported in 2022 that apparently remains unaddressed.
  - rust-lang#100125
- Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO.
- Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 1, 2024
@GuillaumeGomez
Rollup merge of rust-lang#131829 - Zalathar:goodbye-zprofile, r=cheny…
526c67f 
…ukang

Remove support for `-Zprofile` (gcov-style coverage instrumentation)

Tracking issue: rust-lang#42524

MCP: rust-lang/compiler-team#798

---

This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag.

(The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.)

Notably, the `-Zprofile` flag:
- Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful.
- Has no known maintainer.
- Has seen no push towards stabilization.
- Has at least one severe regression reported in 2022 that apparently remains unaddressed.
  - rust-lang#100125
- Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO.
- Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 2, 2024
@rust-timer
Unrolled build for rust-lang#131829
316805b 
Rollup merge of rust-lang#131829 - Zalathar:goodbye-zprofile, r=chenyukang

Remove support for `-Zprofile` (gcov-style coverage instrumentation)

Tracking issue: rust-lang#42524

MCP: rust-lang/compiler-team#798

---

This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag.

(The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.)

Notably, the `-Zprofile` flag:
- Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful.
- Has no known maintainer.
- Has seen no push towards stabilization.
- Has at least one severe regression reported in 2022 that apparently remains unaddressed.
  - rust-lang#100125
- Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO.
- Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.
@workingjubilee
Copy link
Member

Removed: #131829

@workingjubilee workingjubilee closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2024
@workingjubilee workingjubilee added A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2024
@whitequark
Copy link
Member

Aw, that's unfortunate.

@tshepang
Copy link
Member

tshepang commented Nov 9, 2024

@whitequark why so

@whitequark
Copy link
Member

As far as I understand there's no replacement?

@tshepang
Copy link
Member

tshepang commented Nov 9, 2024

was thinking this was for branch coverage, which has since been implemented

@whitequark
Copy link
Member

Oh. I missed that then!

@workingjubilee
Copy link
Member

@whitequark Yes, -Cinstrument-coverage should work and supports the llvm-cov style of handling coverage: https://doc.rust-lang.org/nightly/rustc/instrument-coverage.html

@fadeevab fadeevab mentioned this issue Nov 10, 2024
Closed
@whitequark
Copy link
Member

Oh that's fantastic work =^_^=

@pulsastrix pulsastrix mentioned this issue Nov 20, 2024
Merged
@bushrat011899 bushrat011899 mentioned this issue Mar 1, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-CLI Area: Command-line interface (CLI) to the compiler A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@steveklabnik @whitequark @alexcrichton @tshepang @glandium @Mark-Simulacrum @tylerhawkes @jackh726 @workingjubilee