Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Tracking issue for HashMap::remove_entry #46344

Closed
sfackler opened this issue Nov 28, 2017 · 5 comments
Closed

Tracking issue for HashMap::remove_entry #46344

sfackler opened this issue Nov 28, 2017 · 5 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-enhancement Category: An issue proposing an enhancement or a PR with one. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

We added this to OccupiedEntry a while ago, but weirdly not to the map itself.
@sfackler sfackler mentioned this issue Jan 7, 2018
Merged
@sfackler sfackler changed the title Add HashMap::remove_entry Tracking issue for HashMap::remove_entry Jan 7, 2018
@sfackler sfackler added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 7, 2018
@ghost
Copy link

ghost commented Jan 8, 2018

Should we also add BTreeMap::remove_entry?

kennytm pushed a commit to kennytm/rust that referenced this issue Jan 8, 2018
@sfackler
Add HashMap::remove_entry
1fc6ad5 
Implements rust-lang#46344
kennytm added a commit to kennytm/rust that referenced this issue Jan 8, 2018
@kennytm
Rollup merge of rust-lang#47259 - sfackler:map-remove-entry, r=dtolnay
5ffaf4c 
Add HashMap::remove_entry

Implements rust-lang#46344

r? @dtolnay
@XAMPPRocky XAMPPRocky added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Feb 19, 2018
@SimonSapin
Copy link
Contributor

Looks good to me to stabilize.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Mar 17, 2018 •
edited by aturon
Loading

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Mar 17, 2018
@rfcbot
Copy link

rfcbot commented Mar 19, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 19, 2018
@bluss bluss mentioned this issue Mar 25, 2018
Closed
21 tasks
@rfcbot
Copy link

rfcbot commented Mar 29, 2018

The final comment period is now complete.

@tinaun tinaun mentioned this issue Apr 17, 2018
Merged
bors added a commit that referenced this issue Apr 18, 2018
@bors
Auto merge of #50017 - tinaun:stabilize-all-the-things, r=sfackler
ac3c228 
stabilize a bunch of minor api additions

besides `ptr::NonNull::cast` (which is 4 days away from end of FCP) all of these have been finished with FCP for a few weeks now with minimal issues raised

* Closes #41020
* Closes #42818
* Closes #44030
* Closes #44400
* Closes #46507
* Closes #47653
* Closes #46344

the following functions will be stabilized in 1.27:
* `[T]::rsplit`
* `[T]::rsplit_mut`
* `[T]::swap_with_slice`
* `ptr::swap_nonoverlapping`
* `NonNull::cast`
* `Duration::from_micros`
* `Duration::from_nanos`
* `Duration::subsec_millis`
* `Duration::subsec_micros`
* `HashMap::remove_entry`
@billyrieger billyrieger mentioned this issue Nov 24, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-enhancement Category: An issue proposing an enhancement or a PR with one. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SimonSapin @sfackler @XAMPPRocky @rfcbot