Skip to content

Tracking issue for btreemap_remove_entry #66714

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
billyrieger opened this issue Nov 24, 2019 · 3 comments · Fixed by #70712
Closed

Tracking issue for btreemap_remove_entry #66714

billyrieger opened this issue Nov 24, 2019 · 3 comments · Fixed by #70712
Labels
A-collections Area: `std::collections` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@billyrieger
Copy link
Contributor

HashMap::remove_entry has been stable since 1.27.0 (issue #46344) but there is no corresponding method for BTreeMap. If this is something that should be added I'd be happy to implement it.
@jonas-schievink jonas-schievink added A-collections Area: `std::collections` C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 24, 2019
@hellow554
Copy link
Contributor

@billyrieger feel free to open a PR

@billyrieger billyrieger mentioned this issue Jan 20, 2020
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jan 29, 2020
@JohnTitor
Rollup merge of rust-lang#68378 - billyrieger:btreemap-remove-entry, …
af0c280 
…r=KodrAus

Add BTreeMap::remove_entry

Implements rust-lang#66714.
@billyrieger
Copy link
Contributor Author

Implemented in #68378.

@JohnTitor
Copy link
Member

The method is unstable and this should be tracking issue, re-opening.

@JohnTitor JohnTitor reopened this Feb 28, 2020
@JohnTitor JohnTitor added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC B-unstable Blocker: Implemented in the nightly compiler and unstable. and removed C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Feb 28, 2020
@billyrieger billyrieger changed the title No remove_entry method for BTreeMap Tracking issue for btreemap_remove_entry Mar 13, 2020
@DutchGhost DutchGhost mentioned this issue Apr 2, 2020
Merged
@bors bors closed this as completed in 29fd528 Apr 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-collections Area: `std::collections` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stabilize BTreeMap::remove_entry
4 participants
@hellow554 @jonas-schievink @JohnTitor @billyrieger