-
Notifications
You must be signed in to change notification settings - Fork 13.4k
pub extern functions aren't considered unsafe from other crates #5844
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Still relevant. and I think this should require unsafe block. |
Nominating for milestone 1 (well-defined) |
It appears that this was accepted for Maturity 1, well-defined. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Jul 23, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
May 20, 2021
…ednet `while_let_on_iterator` Improvements fixes: rust-lang#6491 fixes: rust-lang#6231 fixes: rust-lang#5844 fixes: rust-lang#1924 fixes: rust-lang#1033 The check for whether a field can be borrowed should probably be moved to utils at some point, but it would require some cleanup work and knowing what parts can actually be shared. changelog: Suggest `&mut iter` when the iterator is used after the loop. changelog: Suggest `&mut iter` when the iterator is a field in a struct. changelog: Don't lint when the iterator is a field in a struct, and the struct is used in the loop. changelog: Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Compiling these as separate crates doesn't produce an error, but compiling them both as part of the same crate does, as does compiling a crate which uses a function from a different crate which was explicitly marked as
unsafe
. It seems like this should be consistent.The text was updated successfully, but these errors were encountered: