Skip to content

librustc: Make extern functions no longer of *u8 type. #6491

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

pcwalton
Copy link
Contributor

r? @brson

pcwalton added 2 commits May 13, 2013 17:55
This can perhaps be restored in the future. For now this is a precursor to
making typedefs work as expected.
Calling them LLVM asserts still, but that never worked anyway. This
is the backwards compatible part.
@brson
Copy link
Contributor

brson commented May 15, 2013

👻

@graydon graydon closed this Jun 13, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 20, 2021
…ednet

`while_let_on_iterator` Improvements

fixes: rust-lang#6491
fixes: rust-lang#6231
fixes: rust-lang#5844
fixes: rust-lang#1924
fixes: rust-lang#1033

The check for whether a field can be borrowed should probably be moved to utils at some point, but it would require some cleanup work and knowing what parts can actually be shared.

changelog: Suggest `&mut iter` when the iterator is used after the loop.
changelog: Suggest `&mut iter` when the iterator is a field in a struct.
changelog: Don't lint when the iterator is a field in a struct, and the struct is used in the loop.
changelog: Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants