Skip to content

Instead of hiding rustdoc search bar by default, disable it #64305

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
GuillaumeGomez opened this issue Sep 9, 2019 · 2 comments · Fixed by #66578
Closed

Instead of hiding rustdoc search bar by default, disable it #64305

GuillaumeGomez opened this issue Sep 9, 2019 · 2 comments · Fixed by #66578
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

It'd have the advantage of not having the not so pretty effect we have currently when the search bar "appears".
@Centril Centril added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Sep 9, 2019
@Mark-Simulacrum
Copy link
Member

When are we hiding it? Without JS?

@GuillaumeGomez
Copy link
Member Author

No, by default it's not displayed. We make it "appear" when we're done loading the index file.

Centril added a commit to Centril/rust that referenced this issue Nov 20, 2019
@Centril
Rollup merge of rust-lang#66298 - Ppjet6:disable-search-field, r=Guil…
00cbc75 
…laumeGomez

rustdoc: fixes rust-lang#64305: disable search field instead of hidding it

The result seems to be ok but I wasn't entirely sure how to get there. I tried to stay generic a bit but maybe it's not required at all.

@GuillaumeGomez

Signed-off-by: Maxime “pep” Buquet <pep@bouah.net>
@Centril Centril mentioned this issue Nov 20, 2019
Merged
bors added a commit that referenced this issue Nov 20, 2019
@bors
Auto merge of #66578 - Centril:rollup-pgz1v7t, r=Centril
f1b882b 
Rollup of 7 pull requests

Successful merges:

 - #66060 (Making ICEs and test them in incremental)
 - #66298 (rustdoc: fixes #64305: disable search field instead of hidding it)
 - #66457 (Just derive Hashstable in librustc)
 - #66496 (rustc_metadata: Privatize more things)
 - #66514 (Fix selected crate search filter)
 - #66535 (Avoid ICE when `break`ing to an unreachable label)
 - #66573 (Ignore run-make reproducible-build-2 on Mac)

Failed merges:

r? @ghost
@bors bors closed this as completed in 5cbd406 Nov 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rollup of 7 pull requests Centril/rust
3 participants
@Centril @GuillaumeGomez @Mark-Simulacrum