Skip to content

Fix selected crate search filter #66514

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fix selected crate search filter #66514

merged 1 commit into from
Nov 20, 2019

Conversation

GuillaumeGomez
Copy link
Member

Fixes #62929.

r? @kinnison

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2019
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

kinnison
kinnison reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks okay, but I'm not sure how to test it. Can you remind me how to build the stdlib docs with x.py?

@GuillaumeGomez
Copy link
Member Author

Sure, here you go: ./x.py doc src/libstd --stage 1. Then it's generated inside build/[your-archi]/stage1/doc/std/index.html.

@kinnison
Copy link
Contributor

So in local testing it doesn't seem to remember the crate selection for the search field when I build from your branch. Am I meant to run up a local webserver for it to work?

kinnison
kinnison approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, with a little help understanding how Firefox's local storage works on files, I have replicated this working.

@kinnison
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 19, 2019

📌 Commit 00ef5c1 has been approved by kinnison

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Nov 19, 2019 •
edited
Loading

Neat! 🎉

Centril added a commit to Centril/rust that referenced this pull request Nov 20, 2019
@Centril
Rollup merge of rust-lang#66514 - GuillaumeGomez:fix-search-filter-sa…
4bd9168 
…ve, r=kinnison

Fix selected crate search filter

Fixes rust-lang#62929.

r? @kinnison
@Centril Centril mentioned this pull request Nov 20, 2019
Merged
bors added a commit that referenced this pull request Nov 20, 2019
@bors
Auto merge of #66578 - Centril:rollup-pgz1v7t, r=Centril
f1b882b 
Rollup of 7 pull requests

Successful merges:

 - #66060 (Making ICEs and test them in incremental)
 - #66298 (rustdoc: fixes #64305: disable search field instead of hidding it)
 - #66457 (Just derive Hashstable in librustc)
 - #66496 (rustc_metadata: Privatize more things)
 - #66514 (Fix selected crate search filter)
 - #66535 (Avoid ICE when `break`ing to an unreachable label)
 - #66573 (Ignore run-make reproducible-build-2 on Mac)

Failed merges:

r? @ghost
@bors bors merged commit 00ef5c1 into rust-lang:master Nov 20, 2019
@GuillaumeGomez GuillaumeGomez deleted the fix-search-filter-save branch November 20, 2019 23:18
@tesuji tesuji mentioned this pull request Nov 21, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: remember the selected crate in search
5 participants
@GuillaumeGomez @Dylan-DPC-zz @kinnison @bors @JohnTitor