Skip to content

Improve span for "cannot provide explicit generic arguments when impl Trait is used in argument position" #65642

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
varkor opened this issue Oct 20, 2019 · 1 comment · Fixed by #65763
Closed

Improve span for "cannot provide explicit generic arguments when impl Trait is used in argument position" #65642

varkor opened this issue Oct 20, 2019 · 1 comment · Fixed by #65763
Assignees
@rustbot
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented Oct 20, 2019 •
edited by rustbot
Loading

The spans for this error should point to the generic arguments, not the entire path. See #65614 (comment).

This issue has been assigned to @ObsidianMinor via this comment.
@varkor varkor added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints labels Oct 20, 2019
@varkor varkor mentioned this issue Oct 20, 2019
Merged
@JohnTitor JohnTitor added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2019
@ObsidianMinor
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this Oct 24, 2019
@ObsidianMinor ObsidianMinor mentioned this issue Oct 24, 2019
Merged
@bors bors closed this as completed in 2b7cc64 Oct 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rustbot rustbot

Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed APIT with explicit generic args span to specific arg spans ObsidianMinor/rust
4 participants
@varkor @ObsidianMinor @JohnTitor @rustbot