Improve error message for APIT with explicit generic arguments #65614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
changed the title
varkor
force-pushed
the
apit-explicit-generics
branch
from
8016331 to
547259f
Compare
varkor
commented
Oct 20, 2019
| --> $DIR/synthetic-param.rs:23:5 | ||
| | | ||
| LL | Foo::func::<u8>(42); | ||
| | ^^^^^^^^^^^^^^^ | ||
|
|
||
| error[E0632]: cannot provide explicit type parameters when `impl Trait` is used in argument position. | ||
| error[E0632]: cannot provide explicit generic arguments when `impl Trait` is used in argument position | ||
| --> $DIR/synthetic-param.rs:26:5 | ||
| | | ||
| LL | Bar::<i8>::func::<u8>(42); |
There was a problem hiding this comment.
This span is not very good. I'll file a follow up issue.
This is disallowed with type or const generics.
varkor
force-pushed
the
apit-explicit-generics
branch
from
547259f to
2f7c9a2
Compare
|
@bors r+ |
|
📌 Commit 2f7c9a2 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 20, 2019
…tthewjasper Improve error message for APIT with explicit generic arguments This is disallowed with type or const generics. cc rust-lang#61410.
bors
added a commit
that referenced
this pull request
Oct 20, 2019
Rollup of 8 pull requests Successful merges: - #65314 (rustdoc: forward -Z options to rustc) - #65592 (clarify const_prop ICE protection comment) - #65603 (Avoid ICE when include! is used by stdin crate) - #65614 (Improve error message for APIT with explicit generic arguments) - #65629 (Remove `borrowck_graphviz_postflow` from test) - #65633 (Remove leading :: from paths in doc examples) - #65638 (Rename the default argument 'def' to 'default') - #65639 (Fix parameter name in documentation) Failed merges: r? @ghost
16 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is disallowed with type or const generics. cc #61410.