Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

rls no longer builds after rust-lang/rust#65904 #65944

Closed
rust-highfive opened this issue Oct 29, 2019 · 0 comments · Fixed by #65957
Closed

rls no longer builds after rust-lang/rust#65904 #65944

rust-highfive opened this issue Oct 29, 2019 · 0 comments · Fixed by #65957
Assignees
@Xanewok
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #65904, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @matthiaskrgr, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Manishearth, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2019
@Xanewok Xanewok mentioned this issue Oct 30, 2019
Merged
bors added a commit that referenced this issue Oct 30, 2019
@bors
Auto merge of #65957 - Xanewok:update-rls, r=Xanewok
6b2a6ed 
submodules: Bump RLS to 58869107ec162a821a4bee53cdd3f51c84cda3ea

Most importantly it contains rust-lang/rls@d267b49 which fixes the RLS build whenever Clippy is built successfully in Rust CI.

Closes #65944

r? @ghost
@bors bors closed this as completed in 03d537e Oct 31, 2019
@Xanewok Xanewok mentioned this issue Oct 31, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xanewok Xanewok

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: Bump RLS to 58869107ec162a821a4bee53cdd3f51c84cda3ea Xanewok/rust
2 participants
@Xanewok @rust-highfive