Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

submodules: update clippy from 66df92ae to c8e3cfbd #65904

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

matthiaskrgr
Copy link
Member

Changes:

travis: temporarily disable rustfmt ci check until #4742 is resolved
rustup https://github.com/rust-lang/rust/pull/65792/
Fix ICE #4579
Add regression test for ICE #4579
Run update_lints for Unicode lint
Re-add false positive check
Add raw string regression test for useless_format lint
Re-factor useless_format lint
Update Unicode lint tests
[Backported] Rustup to https://github.com/rust-lang/rust/pull/59545

Fixes #65888

r? @oli-obk @Manishearth

Changes:
````
travis: temporarily disable rustfmt ci check until rust-lang#4742 is resolved
rustup rust-lang#65792
Fix ICE rust-lang#4579
Add regression test for ICE rust-lang#4579
Run update_lints for Unicode lint
Re-add false positive check
Add raw string regression test for useless_format lint
Re-factor useless_format lint
Update Unicode lint tests
[Backported] Rustup to rust-lang#59545
````

Fixes #rust-lang#65888
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2019
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 28, 2019

📌 Commit f9ac609 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2019
@tesuji
Copy link
Contributor

tesuji commented Oct 29, 2019

Did you use the clippy on master branch? The clippy commits in this PR seems really old.
image

@Manishearth
Copy link
Member

Manishearth commented Oct 29, 2019 via email

@matthiaskrgr
Copy link
Member Author

Could we get a prio bump? Otherwise this might not land before clippy is broken again.

@Manishearth
Copy link
Member

Manishearth commented Oct 29, 2019 via email

@bors
Copy link
Contributor

bors commented Oct 29, 2019

⌛ Testing commit f9ac609 with merge caa1f8d...

bors added a commit that referenced this pull request Oct 29, 2019
submodules: update clippy from 66df92a to c8e3cfb

Changes:
````
travis: temporarily disable rustfmt ci check until #4742 is resolved
rustup #65792
Fix ICE #4579
Add regression test for ICE #4579
Run update_lints for Unicode lint
Re-add false positive check
Add raw string regression test for useless_format lint
Re-factor useless_format lint
Update Unicode lint tests
[Backported] Rustup to #59545
````

Fixes #65888

r? @oli-obk @Manishearth
@bors
Copy link
Contributor

bors commented Oct 29, 2019

☀️ Test successful - checks-azure
Approved by: Manishearth
Pushing caa1f8d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 29, 2019
@bors bors merged commit f9ac609 into rust-lang:master Oct 29, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #65904!

Tested on commit caa1f8d.
Direct link to PR: #65904

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 rls on windows: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 29, 2019
Tested on commit rust-lang/rust@caa1f8d.
Direct link to PR: <rust-lang/rust#65904>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 rls on windows: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#65885
6 participants