Skip to content

Major async/await compiler performance regression #67706

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Mark-Simulacrum opened this issue Dec 29, 2019 · 9 comments
Closed

Major async/await compiler performance regression #67706

Mark-Simulacrum opened this issue Dec 29, 2019 · 9 comments
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. I-compiletime Issue: Problems and improvements with respect to compile times. P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Something in #67670 caused a major performance regression. Query that regressed is normalize_ty_after_erasing_regions, but not sure if that means much. I suspect that #65244 is the PR responsible, but have no proof.
@Mark-Simulacrum Mark-Simulacrum added I-nominated I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-async-await Area: Async & Await labels Dec 29, 2019
@Centril
Copy link
Contributor

Centril commented Dec 29, 2019

Seems like the most prudent course of action is to create a revert PR for #65244 to see if perf is regained.

@Mark-Simulacrum
Copy link
Member Author

I wouldn't be opposed to such a course. Not sure if I'll have the time to do so for a day or two, though.

@wesleywiser wesleywiser mentioned this issue Jan 1, 2020
Merged
@wesleywiser
Copy link
Member

Testing a revert in #67768

@wesleywiser
Copy link
Member

Looks like #65244 is the cause.

@pnkfelix pnkfelix mentioned this issue Jan 2, 2020
Closed
@pnkfelix
Copy link
Member

pnkfelix commented Jan 2, 2020

triage: P-high; leaving nominated for discussion at meeting (namely discussion of revert)

@pnkfelix pnkfelix added the P-high High priority label Jan 2, 2020
@pnkfelix
Copy link
Member

pnkfelix commented Jan 2, 2020

Discussed in T-compiler meeting.

Members present generally approved a revert of PR #65244 to resolve this issue in short term.

@wesleywiser
Copy link
Member

I guess I should re-open my revert then?

@Mark-Simulacrum
Copy link
Member Author

Yes, please do, and I (or someone else) can review it, I think, fairly quickly.

bors added a commit that referenced this issue Jan 3, 2020
@bors
Auto merge of #67768 - wesleywiser:dnm_test_perf_65244, r=Mark-Simula…
4877e16 
…crum

Revert #65244 for performance reasons

This reverts commit f35517e.

Revert #65244 so we can see if it is the cause of the performance issue in #67706

cc #67644
@tmandry
Copy link
Member

tmandry commented Jan 7, 2020

Fixed in #67768.

@tmandry tmandry closed this as completed Jan 7, 2020
@tmandry tmandry added the AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. label Jan 7, 2020
@tmandry tmandry mentioned this issue Jan 7, 2020
Closed
@yoshuawuyts yoshuawuyts mentioned this issue Nov 10, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. I-compiletime Issue: Problems and improvements with respect to compile times. P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pnkfelix @wesleywiser @Centril @tmandry @Mark-Simulacrum