Skip to content

Revert #65244 for performance reasons #67768

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2020
Merged

Revert #65244 for performance reasons #67768

merged 1 commit into from
Jan 3, 2020

Conversation

wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Jan 1, 2020 •
edited by Centril
Loading

This reverts commit f35517e.

Revert #65244 so we can see if it is the cause of the performance issue in #67706

cc #67644

@rust-highfive
Copy link
Contributor

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2020
@wesleywiser
Copy link
Member Author

r? @ghost

@bors try

@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Jan 1, 2020

⌛ Trying commit 717702d with merge 5671b03c0b64dbbec704a3846ddc7966a6a7eb59...

@wesleywiser wesleywiser mentioned this pull request Jan 1, 2020
Closed
@bors
Copy link
Collaborator

bors commented Jan 1, 2020

☀️ Try build successful - checks-azure
Build commit: 5671b03c0b64dbbec704a3846ddc7966a6a7eb59 (5671b03c0b64dbbec704a3846ddc7966a6a7eb59)

@rust-timer
Copy link
Collaborator

Queued 5671b03c0b64dbbec704a3846ddc7966a6a7eb59 with parent 119307a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 5671b03c0b64dbbec704a3846ddc7966a6a7eb59, comparison URL.

@wesleywiser wesleywiser closed this Jan 1, 2020
@wesleywiser wesleywiser changed the title [perf] DO NOT MERGE test reverting #65244 Revert #65244 for performance reasons Jan 2, 2020
@wesleywiser wesleywiser reopened this Jan 2, 2020
@wesleywiser
Copy link
Member Author

Per compiler team triage meeting (see #67706 (comment)), I'm reopening this for merging.

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 rollup=never

Approving this per compiler team decision and prioritizing as a regression fix. Also marking as no-rollup since we want to avoid the fixes here masking some other regression.

@bors
Copy link
Collaborator

bors commented Jan 2, 2020

📌 Commit 717702d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2020
@bors
Copy link
Collaborator

bors commented Jan 3, 2020

⌛ Testing commit 717702d with merge 4877e16...

bors added a commit that referenced this pull request Jan 3, 2020
@bors
Auto merge of #67768 - wesleywiser:dnm_test_perf_65244, r=Mark-Simula…
4877e16 
…crum

Revert #65244 for performance reasons

This reverts commit f35517e.

Revert #65244 so we can see if it is the cause of the performance issue in #67706

cc #67644
@bors
Copy link
Collaborator

bors commented Jan 3, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 4877e16 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2020
@bors bors merged commit 717702d into rust-lang:master Jan 3, 2020
This was referenced Jan 7, 2020
Closed
Closed
@yoshuawuyts yoshuawuyts mentioned this pull request Jun 8, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wesleywiser @rust-highfive @rust-timer @bors @Mark-Simulacrum @zackmdavis