Skip to content

rustfmt no longer builds after rust-lang/rust#70275 #70280

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rust-highfive opened this issue Mar 22, 2020 · 3 comments · Fixed by #70149
Closed

rustfmt no longer builds after rust-lang/rust#70275 #70280

rust-highfive opened this issue Mar 22, 2020 · 3 comments · Fixed by #70149
Assignees
@topecongiro
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #70275, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @Dylan-DPC, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2020
@matthiaskrgr
Copy link
Member

In order to fix this, it looks like we'd need to bump the rustc-ap deps to 648.0.0.
I tried doing that but I got stuck when I tried updating rustc-ap-syntax which was last updated a month ago and does not provide 648.0.0. https://crates.io/crates/rustc-ap-syntax

@jonas-schievink jonas-schievink mentioned this issue Mar 24, 2020
Closed
@calebcartwright calebcartwright mentioned this issue Mar 24, 2020
Merged
@spastorino
Copy link
Member

Removing nomination, as part of pre-triage we are looking anyways into tool breakage.

@Manishearth
Copy link
Member

Working on it in rust-lang/rustfmt#4095 , but would appreciate help

This was referenced Mar 28, 2020
Merged
Merged
@SimonSapin SimonSapin mentioned this issue Mar 31, 2020
Merged
@Xanewok Xanewok mentioned this issue Mar 31, 2020
Merged
@bors bors closed this as completed in e129923 Apr 5, 2020
bors-servo added a commit to servo/servo that referenced this issue Apr 9, 2020
@bors-servo
Auto merge of #26071 - servo:rustup, r=nox
b045e61 
Upgrade to rustc 1.44.0-nightly (42abbd887 2020-04-07)

~Blocked on rust-lang/rust#70280
bors-servo added a commit to servo/servo that referenced this issue Apr 9, 2020
@bors-servo
Auto merge of #26071 - servo:rustup, r=nox
b600fac 
Upgrade to rustc 1.44.0-nightly (42abbd887 2020-04-07)

~Blocked on rust-lang/rust#70280
bors-servo added a commit to servo/servo that referenced this issue Apr 9, 2020
@bors-servo
Auto merge of #26071 - servo:rustup, r=<try>
b7442d7 
Upgrade to rustc 1.44.0-nightly (42abbd887 2020-04-07)

~Blocked on rust-lang/rust#70280
bors-servo added a commit to servo/servo that referenced this issue Apr 9, 2020
@bors-servo
Auto merge of #26071 - servo:rustup, r=nox
9c33003 
Upgrade to rustc 1.44.0-nightly (42abbd887 2020-04-07)

~Blocked on rust-lang/rust#70280
bors-servo added a commit to servo/servo that referenced this issue Apr 10, 2020
@bors-servo
Auto merge of #26071 - servo:rustup, r=nox
e66705a 
Upgrade to rustc 1.44.0-nightly (42abbd887 2020-04-07)

~Blocked on rust-lang/rust#70280
bors-servo added a commit to servo/servo that referenced this issue Apr 10, 2020
@bors-servo
Auto merge of #26071 - servo:rustup, r=nox
9fd6684 
Upgrade to rustc 1.44.0-nightly (42abbd887 2020-04-07)

~Blocked on rust-lang/rust#70280
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@topecongiro topecongiro

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: Update RLS and Rustfmt Xanewok/rust
5 participants
@spastorino @matthiaskrgr @Manishearth @rust-highfive @topecongiro