-
Notifications
You must be signed in to change notification settings - Fork 13.4k
submodules: Update RLS and Rustfmt #70149
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Fixes only toolstate. @bors r+ p=1 |
📌 Commit cc12885b1992d1178b846fda2ec877e4c3ba3c20 has been approved by |
⌛ Testing commit cc12885b1992d1178b846fda2ec877e4c3ba3c20 with merge 69a613ce73b727d393a30d948d3c81540a158e97... |
💔 Test failed - checks-azure |
Broken again by #69965, working on a fix. |
Updated but I think we'll have to bump
due to #70240 |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@Xanewok just an fyi that we've got the rustc-ap-* crates updated now in both racer and rustfmt. There's a couple minor changes that need to be squeezed in for rustfmt (including bumping the version of rustfmt) before updating the submods |
@calebcartwright Thank you for your work, just published rustfmt 1.4.13 on crates.io. |
@calebcartwright thank you for working on it! Just pushed a change with update to both RLS and Rustfmt and confirmed locally that this fixes both RLS and Rustfmt. |
@topecongiro could you please double-check the changes to rustfmt submodule? r=me once everything looks good from your side |
On it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@bors r+ |
📌 Commit 284f47a6b4584796bb1e410b362a674cb26ebad7 has been approved by |
⌛ Testing commit 284f47a6b4584796bb1e410b362a674cb26ebad7 with merge e9a6ec89b15dfa1d622a3667484a1976b74724f2... |
@bors retry (yield) |
@Dylan-DPC it would be great if we could land this before nightly cutoff since rustfmt has been broken for around a week now. |
@bors p=20 |
Added 4387a8b, let's see what |
@bors p=1000 |
@bors treeclosed=100 |
@Xanewok can you ping me somewhere? :P (discord or zulip) |
Let's queue this up again: @bors r+ |
📌 Commit 1e4e5c46139ea531fc79d2339ad01b36f9503c3a has been approved by |
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
@bors treeclosed- |
⌛ Testing commit 1e4e5c46139ea531fc79d2339ad01b36f9503c3a with merge c028cae9287b8be0712a32bb5341b14636c338fa... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Just to be clear, the |
@Xanewok can you rebase this? |
@Dylan-DPC if this won't automatically stop the current homu run then I can rebase this, sure. |
I think that was the case unfortunately @bors r+ |
📌 Commit 370be8e has been approved by |
☀️ Test successful - checks-azure |
📣 Toolstate changed by #70149! Tested on commit e129923. 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). |
Tested on commit rust-lang/rust@e129923. Direct link to PR: <rust-lang/rust#70149> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok). 🎉 rustfmt on windows: build-fail → test-pass (cc @topecongiro). 🎉 rustfmt on linux: build-fail → test-pass (cc @topecongiro).
Fixes #70129.
Fixes #70280.
Regression fixed specifically with rust-lang/rls@4a587b5.
r? @ghost