Parser will not suggest invalid expression when use public #100188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @estebank |
ghost
suggested changes
Aug 7, 2022
ghost
reviewed
Aug 7, 2022
|
@chenyukang Remember to squash your commits 👏🏻 |
chenyukang
force-pushed
the
fix-issue-100165
branch
from
3337844 to
863488d
Compare
|
|
@bors r+ |
bors
added
S-waiting-on-bors
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Aug 20, 2022
…ebank Parser will not suggest invalid expression when use public Fixes rust-lang#100165
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 20, 2022
…ebank Parser will not suggest invalid expression when use public Fixes rust-lang#100165
This was referenced Aug 20, 2022
|
☔ The latest upstream changes (presumably #100793) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
You'll have to rebase on top of a more recent version of the repo before we can merge. |
chenyukang
force-pushed
the
fix-issue-100165
branch
from
863488d to
3747499
Compare
|
Some changes occurred in src/tools/cargo cc @ehuss The Miri submodule was changed cc @rust-lang/miri |
|
ooo, seems pushed some extra changes, let me fix it. |
chenyukang
force-pushed
the
fix-issue-100165
branch
from
3747499 to
ef4594a
Compare
Please ignore it. |
|
☔ The latest upstream changes (presumably #100904) made this pull request unmergeable. Please resolve the merge conflicts. |
chenyukang
force-pushed
the
fix-issue-100165
branch
from
ef4594a to
e1d7a27
Compare
chenyukang
force-pushed
the
fix-issue-100165
branch
from
e1d7a27 to
351acc8
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 24, 2022
…ebank Parser will not suggest invalid expression when use public Fixes rust-lang#100165
This was referenced Aug 24, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99332 (Stabilize `#![feature(label_break_value)]`) - rust-lang#99954 (let-else: break out to one scope higher for let-else) - rust-lang#100188 (Parser will not suggest invalid expression when use public) - rust-lang#100780 (save_analysis: Migrate diagnostic) - rust-lang#100808 (Migrate `rustc_interface` diagnostics ) - rust-lang#100921 (Add a warning about `Option/Result::and()` being eagerly evaluated) - rust-lang#100960 (rustdoc: ayu code color selector more specific) - rust-lang#100964 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100165