Add a warning about Option/Result::and() being eagerly evaluated
#100921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from `or()`.
rustbot
added
the
T-libs
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
the
A-docs
Sounds like it would make sense to add a clippy lint for and(). Maybe open an issue? |
JohnTitor
approved these changes
Aug 24, 2022
|
Looks good, thanks! r? @JohnTitor @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99332 (Stabilize `#![feature(label_break_value)]`) - rust-lang#99954 (let-else: break out to one scope higher for let-else) - rust-lang#100188 (Parser will not suggest invalid expression when use public) - rust-lang#100780 (save_analysis: Migrate diagnostic) - rust-lang#100808 (Migrate `rustc_interface` diagnostics ) - rust-lang#100921 (Add a warning about `Option/Result::and()` being eagerly evaluated) - rust-lang#100960 (rustdoc: ayu code color selector more specific) - rust-lang#100964 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from
or().Inspired by this StackOverflow question.
The PR for
or()mentions the Clippy lintor_fun_callwhich doesn't exist forand()(although there isunnecessary_lazy_evaluations). I still think this warning is also good forand(). Feel free to close if you disagree.