Rollup of 11 pull requests #100511
Merged
Rollup of 11 pull requests #100511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM commit llvm/llvm-project@057cabd removed the function from the msan error message. This adapts our test accordingly. Found via our experimental rust + llvm @ HEAD bot: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/12634#018289fe-b0bc-4bab-89b3-fb1d4e38f6db
Before, it would fail with "error: ignoring unknown argument '-Wl,--icf=all'"
See rust-lang#100354 for the rationale.
Reasons: 1. It's shorter. 2. `@matches-literal` seems to contradict itself: a regex is intrinsically not a literal match, while it is still a textual match.
I think `@hasraw` is slightly clearer than `@hastext` since it is actually matching against the raw HTML, not the text nodes.
`@!has` (and `@!matches`) with two arguments used to treat the second argument as a literal string of HTML code. Now, that feature has been renamed into `@!hasraw` (and `@!matchesraw`), and the arity-2 `@!has` version is an error. These uses thought the second argument was being treated as an XPath, as with the arity-3 version, but in fact was being treated as literal HTML. Because these were checking for the *absence* of the string, the tests silently did nothing -- an XPath string won't ever be showing up in the test's generated HTML!
rustdoc: Rename `@has FILE PATTERN` to `@hasraw FILE PATTERN` Fixes rust-lang#100354.
…crum avoid some int2ptr casts in thread_local_key tests
…gillot Fix HIR pretty printing of let else Fixes rust-lang#100373 Fixes rust-lang#99318 Fixes rust-lang#99319
Erase regions better in `promote_candidate` Use `tcx.erase_regions` instead of manually walking through the substs.... this also makes the code slightly simpler 🙈 Fixes rust-lang#100360 Fixes rust-lang#89851
adapt test for msan message change LLVM commit llvm/llvm-project@057cabd removed the function from the msan error message. This adapts our test accordingly. Found via our experimental rust + llvm @ HEAD bot: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/12634#018289fe-b0bc-4bab-89b3-fb1d4e38f6db
…lan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? ``@Dylan-DPC``
Make `[rust] use-lld=true` work on windows Before, it would fail with "error: ignoring unknown argument '-Wl,--icf=all'" This option was introduced in rust-lang#99062 (well, technically rust-lang#99680) See zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/rust-lld.3A.20error.3A.20ignoring.20unknown.20argument.20'-Wl.2C--icf.3Dall'
Give a helpful diagnostic when the next struct field has an attribute Fixes rust-lang#100461
wf: correctly `shallow_resolve` consts `shallow_resolve` on `InferConst` is always a noop. this is mostly irrelevant as inference vars should already be resolved at most - if not all - call sites. Haven't actually looked too deeply into whether this was a problem.
…=Mark-Simulacrum nicer Miri backtraces for from_exposed_addr Miri by default warns about using from_exposed_addr; this makes the span for that a bit nicer.
…k_trait_bound, r=compiler-errors merge two test directories that mean the same thing hopefully `hrtb` doesnt have a secret second meaning that i'm not aware of 😆 r? `@compiler-errors`
rustbot
added
the
T-bootstrap
rustbot
added
T-compiler
|
@bors r+ rollup=never p=9 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Aug 14, 2022
|
Finished benchmarking commit (b76fec3): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
|
Regarding perf, I saw both of these tests also regress in #100510 -- I feel like it's just noise. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
@has FILE PATTERNto@hasraw FILE PATTERN#100355 (rustdoc: Rename@has FILE PATTERNto@hasraw FILE PATTERN)promote_candidate#100438 (Erase regions better inpromote_candidate)[rust] use-lld=truework on windows #100464 (Make[rust] use-lld=truework on windows)shallow_resolveconsts #100490 (wf: correctlyshallow_resolveconsts)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup