Skip to content

Point to generic or arg if it's the self type of unsatisfied projection predicate #100483

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

compiler-errors
Copy link
Member

We do this for TraitPredicates in point_at_type_arg_instead_of_call_if_possible and point_at_arg_instead_of_call_if_possible, so also do it for ProjectionPredicate.

Improves spans for a lot of unit tests.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 13, 2022
@rust-highfive
Copy link
Contributor

r? @spastorino

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2022
@compiler-errors compiler-errors force-pushed the point-to-projection-too branch from d41a24d to 92185c0 Compare August 13, 2022 07:20
@compiler-errors
Copy link
Member Author

@bors r=jyn514

@bors
Copy link
Collaborator

bors commented Aug 13, 2022

📌 Commit 92185c0a603735eaebba8c0e286a0af29d84d9fc has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022
@compiler-errors
Copy link
Member Author

@bors rollup

@bors
Copy link
Collaborator

bors commented Aug 14, 2022

☔ The latest upstream changes (presumably #100511) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2022
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99646 (Only point out a single function parameter if we have a single arg incompatibility)
 - rust-lang#100299 (make `clean::Item::span` return `Option` instead of dummy span)
 - rust-lang#100335 (Rustdoc-Json: Add `Path` type for traits.)
 - rust-lang#100367 (Suggest the path separator when a dot is used on a trait)
 - rust-lang#100431 (Enum variant ctor inherits the stability of the enum variant)
 - rust-lang#100446 (Suggest removing a semicolon after impl/trait items)
 - rust-lang#100468 (Use an extensionless `x` script for non-Windows)
 - rust-lang#100479 (Argument type error improvements)

Failed merges:

 - rust-lang#100483 (Point to generic or arg if it's the self type of unsatisfied projection predicate)

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors compiler-errors force-pushed the point-to-projection-too branch from 92185c0 to 54edf18 Compare August 14, 2022 20:28
@compiler-errors
Copy link
Member Author

@bors r=jyn514

@bors
Copy link
Collaborator

bors commented Aug 14, 2022

📌 Commit 54edf18 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 15, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#100211 (Refuse to codegen an upstream static.)
 - rust-lang#100277 (Simplify format_args builtin macro implementation.)
 - rust-lang#100483 (Point to generic or arg if it's the self type of unsatisfied projection predicate)
 - rust-lang#100506 (change `InlineAsmCtxt` to not talk about `FnCtxt`)
 - rust-lang#100534 (Make code slightly more uniform)
 - rust-lang#100566 (Use `create_snapshot_for_diagnostic` instead of `clone` for `Parser`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ee63d09 into rust-lang:master Aug 15, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 15, 2022
@compiler-errors compiler-errors deleted the point-to-projection-too branch August 11, 2023 20:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants