-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Provide structured suggestion for hashmap[idx] = val
#101002
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
r? @davidtwco |
err.help(format!("to modify a `{ty}`, use `.get_mut()`, `.insert()` or the entry API")); | ||
struct V<'a, 'b, 'tcx, G: EmissionGuarantee> { | ||
assign_span: Span, | ||
err: &'a mut DiagnosticBuilder<'b, G>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use &mut Diagnostic
here to remove the generic G
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after resolving @fmease and @compiler-errors' comments
@bors r+ |
Provide structured suggestion for `hashmap[idx] = val`
Provide structured suggestion for `hashmap[idx] = val`
…iaskrgr Rollup of 13 pull requests Successful merges: - rust-lang#97015 (std::io: migrate ReadBuf to BorrowBuf/BorrowCursor) - rust-lang#98301 (Add GDB/LLDB pretty-printers for NonZero types) - rust-lang#99570 (Box::from(slice): Clarify that contents are copied) - rust-lang#100296 (Add standard C error function aliases to last_os_error) - rust-lang#100520 (Add mention of `BufReader` in `Read::bytes` docs) - rust-lang#100885 (Export Cancel from std::os::fortanix_sgx::usercalls::raw) - rust-lang#100955 (Some papercuts on error::Error) - rust-lang#101002 (Provide structured suggestion for `hashmap[idx] = val`) - rust-lang#101038 (no alignment check during interning) - rust-lang#101055 (Use smaller span for suggestions) - rust-lang#101091 (Extend attrs if local_def_id exists) - rust-lang#101098 (rustc_middle: Remove `Visibility::Invisible`) - rust-lang#101102 (unstable-book-gen: use std::fs::write) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
No description provided.