Skip to content

no alignment check during interning #101038

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Conversation

RalfJung
Copy link
Member

This should fix #101034
r? @oli-obk

Unfortunately we don't have a self-contained testcase for this problem. I am not sure how it can be triggered...

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 26, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2022
@RalfJung RalfJung force-pushed the interning-alignment branch from 3a8c1c4 to b85178a Compare August 26, 2022 12:15
@oli-obk
Copy link
Contributor

oli-obk commented Aug 26, 2022

Minimal repro:

#[repr(packed)]
pub struct Foo {
    bar: u8,
    baa: [u32; 1],
}

const FOOMP: Foo = Foo {
    bar: 0,
    baa: [69; 1],
};

@RalfJung
Copy link
Member Author

This doesn't repro on the playground where I did my other tests...

... but turns out playground has an outdated Miri.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 26, 2022

I tested it locally with the -Z flag, so it works for rustc ^^

@RalfJung
Copy link
Member Author

Confirmed, and added a test.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 26, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2022

📌 Commit 468c617 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2022
…iaskrgr

Rollup of 13 pull requests

Successful merges:

 - rust-lang#97015 (std::io: migrate ReadBuf to BorrowBuf/BorrowCursor)
 - rust-lang#98301 (Add GDB/LLDB pretty-printers for NonZero types)
 - rust-lang#99570 (Box::from(slice): Clarify that contents are copied)
 - rust-lang#100296 (Add standard C error function aliases to last_os_error)
 - rust-lang#100520 (Add mention of `BufReader` in `Read::bytes` docs)
 - rust-lang#100885 (Export Cancel from std::os::fortanix_sgx::usercalls::raw)
 - rust-lang#100955 (Some papercuts on error::Error)
 - rust-lang#101002 (Provide structured suggestion for `hashmap[idx] = val`)
 - rust-lang#101038 (no alignment check during interning)
 - rust-lang#101055 (Use smaller span for suggestions)
 - rust-lang#101091 (Extend attrs if local_def_id exists)
 - rust-lang#101098 (rustc_middle: Remove `Visibility::Invisible`)
 - rust-lang#101102 (unstable-book-gen: use std::fs::write)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b80814 into rust-lang:master Aug 28, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 28, 2022
@RalfJung RalfJung deleted the interning-alignment branch August 28, 2022 15:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE in teensy4-fcb 0.3.0: error during interning should later cause validation failure
5 participants