Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Point out incompatible closure bounds #101360

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Point out incompatible closure bounds #101360

merged 1 commit into from
Oct 11, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #100295

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 3, 2022
@rust-highfive
Copy link
Contributor

r? @fee1-dead

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2022
fee1-dead
fee1-dead reviewed Sep 3, 2022
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't dealt with anonymize_* functions at all, but the implementation looks good to me on a glance.

Rerolling.

@fee1-dead

This comment was marked as duplicate.

# to view
@fee1-dead
Copy link
Member

r? rust-lang/compiler

@petrochenkov
Copy link
Contributor

I haven't dealt with anonymize_* functions at all, but the implementation looks good to me on a glance.

Same.

@petrochenkov
Copy link
Contributor

Could you maybe move the added code to a separate function (with a comment briefly describing which cases it covers)?
The logic here seems to be entirely isolated.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2022
@compiler-errors
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 25, 2022
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 6, 2022

📌 Commit ce836c8f30903fbff9395767c40478a016ac5e97 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2022
@bors
Copy link
Collaborator

bors commented Oct 7, 2022

⌛ Testing commit ce836c8f30903fbff9395767c40478a016ac5e97 with merge 95d55b18c54903690216e1b17b81e376c5889363...

@bors
Copy link
Collaborator

bors commented Oct 7, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 7, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2022
@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 7, 2022
@compiler-errors compiler-errors force-pushed the multiple-closure-bounds branch from ce836c8 to 6934853 Compare October 10, 2022 05:05
@compiler-errors
Copy link
Member Author

just needed to rebase a PR that relabeled lifetimes in binders, which changed the UI output.

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Oct 10, 2022

📌 Commit 6934853 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 10, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 10, 2022
@Dylan-DPC
Rollup merge of rust-lang#101360 - compiler-errors:multiple-closure-b…
8921e6b 
…ounds, r=petrochenkov

Point out incompatible closure bounds

Fixes rust-lang#100295
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 10, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 10, 2022
@Dylan-DPC
Rollup merge of rust-lang#101360 - compiler-errors:multiple-closure-b…
b5a59cf 
…ounds, r=petrochenkov

Point out incompatible closure bounds

Fixes rust-lang#100295
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 10, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2022
@bors
Auto merge of rust-lang#102896 - matthiaskrgr:rollup-jg5xawz, r=matth…
518263d 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#101360 (Point out incompatible closure bounds)
 - rust-lang#101789 (`let`'s not needed in struct field definitions)
 - rust-lang#102846 (update to syn-1.0.102)
 - rust-lang#102871 (rustdoc: clean up overly complex `.trait-impl` CSS selectors)
 - rust-lang#102876 (suggest candidates for unresolved import)
 - rust-lang#102888 (Improve rustdoc-gui search-color test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d8d01e3 into rust-lang:master Oct 11, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 11, 2022
@compiler-errors compiler-errors deleted the multiple-closure-bounds branch November 2, 2022 02:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

Multiple Fn bounds
7 participants
@compiler-errors @rust-highfive @fee1-dead @petrochenkov @bors @rust-log-analyzer @rustbot