Skip to content

Improve rustdoc-gui search-color test #102888

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

Improve rustdoc-gui search-color test #102888

merged 2 commits into from
Oct 11, 2022

Conversation

GuillaumeGomez
Copy link
Member

Thanks to the add of "functions" in browser-ui-test, we can start to reduce the size of the scripts. It'll be very useful for all color checks.

r? @notriddle

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 10, 2022
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 10, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2022
@GuillaumeGomez GuillaumeGomez changed the title Improve search color check Improve rustdoc-gui search color check Oct 10, 2022
@GuillaumeGomez GuillaumeGomez changed the title Improve rustdoc-gui search color check Improve rustdoc-gui search-color test Oct 10, 2022
@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 10, 2022

📌 Commit 9c5a769 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2022
@bors
Auto merge of rust-lang#102896 - matthiaskrgr:rollup-jg5xawz, r=matth…
518263d 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#101360 (Point out incompatible closure bounds)
 - rust-lang#101789 (`let`'s not needed in struct field definitions)
 - rust-lang#102846 (update to syn-1.0.102)
 - rust-lang#102871 (rustdoc: clean up overly complex `.trait-impl` CSS selectors)
 - rust-lang#102876 (suggest candidates for unresolved import)
 - rust-lang#102888 (Improve rustdoc-gui search-color test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a52eba4 into rust-lang:master Oct 11, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 11, 2022
@GuillaumeGomez GuillaumeGomez deleted the improve-search-color-check branch October 11, 2022 09:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @notriddle @bors @rust-highfive @rustbot