Skip to content

rustdoc: remove unused CSS div.impl-items > div #101580

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

notriddle
Copy link
Contributor

This was added in 9077d54 to override the style on <div> tags that were acting as headers. These <div> tags were replaced with <section> tags in 32f6260, but this CSS was probably already redundant even then (the headers had already been replaced with real <h3> and <h4> tags in 76a3b60).

This was added in 9077d54 to override the
style on `<div>` tags that were acting as headers. These `<div>` tags were
replaced with `<section>` tags in 32f6260,
but this CSS was probably already redundant even then (the headers had
already been replaced with real `<h3>` and `<h4>` tags in
76a3b60).
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 8, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2022
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Sep 8, 2022

📌 Commit f7b10b9 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2022
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Sep 8, 2022
…-div, r=GuillaumeGomez

rustdoc: remove unused CSS `div.impl-items > div`

This was added in 9077d54 to override the style on `<div>` tags that were acting as headers. These `<div>` tags were replaced with `<section>` tags in 32f6260, but this CSS was probably already redundant even then (the headers had already been replaced with real `<h3>` and `<h4>` tags in 76a3b60).
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2022
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#101423 (Fix hermit warnings)
 - rust-lang#101499 (Introduce lowering_arena to avoid creating AST nodes on the fly)
 - rust-lang#101530 (llvm-wrapper: adapt for LLVM API changes)
 - rust-lang#101554 (rustdoc: remove unused CSS `#implementations-list > h3 > span.in-band`)
 - rust-lang#101580 (rustdoc: remove unused CSS `div.impl-items > div`)
 - rust-lang#101584 (rustdoc: remove no-op CSS `#settings-menu { padding: 0 }`)
 - rust-lang#101587 (Make `Debug` impl for `Term` useful)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b300123 into rust-lang:master Sep 9, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 9, 2022
@notriddle notriddle deleted the notriddle/div-impl-items-div branch September 13, 2022 00:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants