Make Debug impl for Term useful
#101587
Merged
Make Debug impl for Term useful
#101587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r=me when ci is green, since i am out at lunch |
|
@bors r= compiler-errors |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
| pub struct Term<'tcx> { | ||
| ptr: NonZeroUsize, | ||
| marker: PhantomData<(Ty<'tcx>, Const<'tcx>)>, | ||
| } | ||
|
|
||
| impl Debug for Term<'_> { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| let data = if let Some(ty) = self.ty() { |
There was a problem hiding this comment.
this is a nit but shouldn't this just match on self.unpack()
There was a problem hiding this comment.
xd I didn't know that method existed
There was a problem hiding this comment.
Shouldn't this just print unpack()?
There was a problem hiding this comment.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 8, 2022
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#101423 (Fix hermit warnings) - rust-lang#101499 (Introduce lowering_arena to avoid creating AST nodes on the fly) - rust-lang#101530 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#101554 (rustdoc: remove unused CSS `#implementations-list > h3 > span.in-band`) - rust-lang#101580 (rustdoc: remove unused CSS `div.impl-items > div`) - rust-lang#101584 (rustdoc: remove no-op CSS `#settings-menu { padding: 0 }`) - rust-lang#101587 (Make `Debug` impl for `Term` useful) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because
Term { ptr: 78942378998734298342, maker: PhantomData, }does not excel at communicating the necessary information