Skip to content

change AccessLevels representation #101713

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2022
Merged

change AccessLevels representation #101713

merged 1 commit into from
Sep 18, 2022

Conversation

Bryanskiy
Copy link
Contributor

Part of RFC (#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it.

r? @petrochenkov

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 12, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@petrochenkov
Copy link
Contributor

Could you include the testing stuff from #100962 (src/test/ui/privacy/access_levels.rs and its compiler implementation) into this PR?

petrochenkov
petrochenkov reviewed Sep 12, 2022
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
@rust-log-analyzer

This comment was marked as resolved.

# to view
petrochenkov
petrochenkov reviewed Sep 13, 2022
View reviewed changes
@petrochenkov
Copy link
Contributor

Possible improvement for the borrow checker problem - petrochenkov@32fd8f7.

@rustbot rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Sep 13, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@Bryanskiy
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2022
petrochenkov
petrochenkov reviewed Sep 14, 2022
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2022
petrochenkov
petrochenkov reviewed Sep 14, 2022
View reviewed changes
@petrochenkov
Copy link
Contributor

r=me after applying the final cleanups and squashing commits.

@Bryanskiy
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2022
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 14, 2022

📌 Commit d7b9221 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 14, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 15, 2022
@Dylan-DPC
Rollup merge of rust-lang#101713 - Bryanskiy:AccessLevels, r=petroche…
8b283b9 
…nkov

change AccessLevels representation

Part of RFC (rust-lang#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it.

r? `@petrochenkov`
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 15, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 15, 2022
@Dylan-DPC
Rollup merge of rust-lang#101713 - Bryanskiy:AccessLevels, r=petroche…
3353e73 
…nkov

change AccessLevels representation

Part of RFC (rust-lang#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it.

r? ``@petrochenkov``
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 15, 2022
Closed
@bors
Copy link
Collaborator

bors commented Sep 16, 2022

⌛ Testing commit d7b9221 with merge 30567c4f2b19c6c6ee49dc28f20116adb5221ee5...

@bors
Copy link
Collaborator

bors commented Sep 16, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 16, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@petrochenkov
Copy link
Contributor

Timeout.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 16, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101713 - Bryanskiy:AccessLevels, r=petroche…
334b2d4 
…nkov

change AccessLevels representation

Part of RFC (rust-lang#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it.

r? `@petrochenkov`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 16, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
@bors
Auto merge of rust-lang#101949 - matthiaskrgr:rollup-xu5cqnd, r=matth…
5253b0a 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#101093 (Initial version of 1.64 release notes)
 - rust-lang#101713 (change AccessLevels representation)
 - rust-lang#101821 (Bump Unicode to version 15.0.0, regenerate tables)
 - rust-lang#101826 (Enforce "joined()" and "joined_with_noop()" test)
 - rust-lang#101835 (Allow using vendoring when running bootstrap from outside the source root)
 - rust-lang#101942 (Revert "Copy stage0 binaries into stage0-sysroot")
 - rust-lang#101943 (rustdoc: remove unused CSS `.non-exhaustive { margin-bottom }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a6b34cd into rust-lang:master Sep 18, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 18, 2022
@Bryanskiy Bryanskiy mentioned this pull request Sep 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 16, 2022
@bors
Auto merge of rust-lang#102026 - Bryanskiy:resolve_update, r=petroche…
b8b5cae 
…nkov

Populate effective visibilities in 'rustc_resolve'

Next part of RFC rust-lang#48054.
previous: rust-lang#101713

`@rustbot` author
r? `@petrochenkov`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Oct 21, 2022
@bors
Auto merge of #102026 - Bryanskiy:resolve_update, r=petrochenkov
aadd872 
Populate effective visibilities in 'rustc_resolve'

Next part of RFC rust-lang/rust#48054.
previous: rust-lang/rust#101713

`@rustbot` author
r? `@petrochenkov`
@Bryanskiy Bryanskiy deleted the AccessLevels branch May 18, 2023 12:53
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024
@bors
Auto merge of #102026 - Bryanskiy:resolve_update, r=petrochenkov
c56cd3e 
Populate effective visibilities in 'rustc_resolve'

Next part of RFC rust-lang/rust#48054.
previous: rust-lang/rust#101713

`@rustbot` author
r? `@petrochenkov`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@bors
Auto merge of #102026 - Bryanskiy:resolve_update, r=petrochenkov
5e1bd6c 
Populate effective visibilities in 'rustc_resolve'

Next part of RFC rust-lang/rust#48054.
previous: rust-lang/rust#101713

`@rustbot` author
r? `@petrochenkov`
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Bryanskiy @rust-log-analyzer @petrochenkov @rustbot @bors @rust-highfive