Add loongarch64 abi support #101939
Add loongarch64 abi support #101939
Conversation
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
As far as I can tell this adds a new Tier 3 target. There are instructions at https://doc.rust-lang.org/rustc/target-tier-policy.html#tier-3-target-policy for the conditions that need to be met in order to add such a target. Please create an MCP for adding the new target. |
|
The MCP is rust-lang/compiler-team#518 and is now accepted. Can this PR be reviewed or are there other middle steps? Also, what's the relationship between this PR and #96971? Should they progress together? Should they share the reviewers (i.e. same people having the context)? thanks |
|
@bors r+ Seems fine to merge this now and deduplicate later |
bors
added
S-waiting-on-bors
…earth Rollup of 9 pull requests Successful merges: - rust-lang#101939 (Add loongarch64 abi support) - rust-lang#103863 (Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor) - rust-lang#104036 (Suggest `is_some` when we've found `Option` but expected `bool`) - rust-lang#104060 (Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher`) - rust-lang#104077 (Use aapcs for efiapi calling convention on arm) - rust-lang#104186 (Tighten the 'introduce new binding' suggestion) - rust-lang#104194 (`EarlyBinder` docs) - rust-lang#104233 (Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor`) - rust-lang#104235 (Use `const_error_with_guaranteed` more) Failed merges: - rust-lang#104078 (Print "Checking/Building ..." message even when --dry-run is passed) - rust-lang#104169 (Migrate `:target` rules to use CSS variables) r? `@ghost` `@rustbot` modify labels: rollup
|
@zhaixiaojuan: Please kindly cc me for further LoongArch changes. In this PR you used the RISC-V terminology "XLEN" and "FLEN", while they should be "GRLen" and "FRLen" respectively for LoongArch, even if they're actually analogues (with the LoongArch taking the concept from RISC-V). Fortunately the rest looks correct. |
Ok |
No description provided.