-
Notifications
You must be signed in to change notification settings - Fork 13.3k
sync thread_local key conditions exactly with what the macro uses #102783
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Yep, LGTM. @bors r+ |
sync thread_local key conditions exactly with what the macro uses This makes the `cfg` in `mod.rs` syntactically the same as those in `local.rs`. I don't think this should actually change anything, but seems better to be consistent? I looked into this due to rust-lang#102549, but this PR would make it *less* likely that `__OsLocalKeyInner` is going to get provided, so this cannot help with that issue. r? `@thomcc`
@bors r- |
@bors rollup=iffy r=thomcc |
📌 Commit 053f834bdbbffe755f6206598a160021f647ef4f has been approved by It is now in the queue for this repository. |
@bors rollup=iffy r=thomcc |
📌 Commit 527fa5f683381f5d9fd721c7368c8930db8f91fc has been approved by It is now in the queue for this repository. |
@thomcc I realized there is a smarter way to avoid the warning about |
@bors r=thomcc |
This comment has been minimized.
This comment has been minimized.
⌛ Testing commit 5218e24 with merge 7a58723a62744a73f1a94066a93e981f82b6a3f3... |
💔 Test failed - checks-actions |
sync thread_local key conditions exactly with what the macro uses This makes the `cfg` in `mod.rs` syntactically the same as those in `local.rs`. I don't think this should actually change anything, but seems better to be consistent? I looked into this due to rust-lang#102549, but this PR would make it *less* likely that `__OsLocalKeyInner` is going to get provided, so this cannot help with that issue. r? `@thomcc`
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors retry failed to download llvm from ci |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5819f41): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
sync thread_local key conditions exactly with what the macro uses This makes the `cfg` in `mod.rs` syntactically the same as those in `local.rs`. I don't think this should actually change anything, but seems better to be consistent? I looked into this due to rust-lang#102549, but this PR would make it *less* likely that `__OsLocalKeyInner` is going to get provided, so this cannot help with that issue. r? `@thomcc`
This makes the
cfg
inmod.rs
syntactically the same as those inlocal.rs
.I don't think this should actually change anything, but seems better to be consistent?
I looked into this due to #102549, but this PR would make it less likely that
__OsLocalKeyInner
is going to get provided, so this cannot help with that issue.r? @thomcc