Skip to content

Fix suggest_floating_point_literal ICE #103003

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2022
Merged

Fix suggest_floating_point_literal ICE #103003

merged 3 commits into from
Oct 15, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Oct 13, 2022

Fixes #102989

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 13, 2022
@rust-highfive
Copy link
Contributor

r? @eholk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@compiler-errors
Copy link
Member

Hm, I would usually discourage fixing ICEs with no_core but this fixes the ICE and also makes the code cleaner... so it's fine.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 13, 2022

📌 Commit 9b8aa65 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 13, 2022
@matthiaskrgr
Rollup merge of rust-lang#103003 - TaKO8Ki:fix-102989, r=compiler-errors
e991efd 
Fix `suggest_floating_point_literal` ICE

Fixes rust-lang#102989
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 13, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r-
failed in a rollup, maybe due to interaction with a different pr? #103022 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2022
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 14, 2022

@bors try

@bors
Copy link
Collaborator

bors commented Oct 14, 2022

⌛ Trying commit 5378677 with merge 2b2d78f4f3e323d2aaa4511745fe7befe6878d90...

@bors
Copy link
Collaborator

bors commented Oct 14, 2022

☀️ Try build successful - checks-actions
Build commit: 2b2d78f4f3e323d2aaa4511745fe7befe6878d90 (2b2d78f4f3e323d2aaa4511745fe7befe6878d90)

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 14, 2022

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Oct 14, 2022

📌 Commit 5378677 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2022
albertlarsan68 added a commit to albertlarsan68/rust that referenced this pull request Oct 14, 2022
@albertlarsan68
Rollup merge of rust-lang#103003 - TaKO8Ki:fix-102989, r=compiler-errors
639095b 
Fix `suggest_floating_point_literal` ICE

Fixes rust-lang#102989
@albertlarsan68 albertlarsan68 mentioned this pull request Oct 14, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#103003 - TaKO8Ki:fix-102989, r=compiler-errors
7f716ba 
Fix `suggest_floating_point_literal` ICE

Fixes rust-lang#102989
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2022
Closed
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 14, 2022 •
edited
Loading

@bors r=
@bors rollup-

@bors
Copy link
Collaborator

bors commented Oct 14, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Oct 14, 2022

📌 Commit 5378677 has been approved by ``

It is now in the queue for this repository.

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 14, 2022

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2022
@compiler-errors
Copy link
Member

@TaKO8Ki this is currently in a rollup, if you meant to cancel the r+ then you should cancel those too.

@compiler-errors
Copy link
Member

Oh wait, you commented on that.

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 14, 2022

@compiler-errors I found a little bit smaller example as I commented in #102989 (comment). It can remove -Cinstrument-coverage and no_core feature and solve a CI error #103055 (comment). Could you review again?

@compiler-errors
Copy link
Member

Does the test reproduce the ICE if you remove those flags, though? I can't test locally since I am away from my computer.

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 14, 2022

Yes. It reproduces the ICE both locally and in the playground.

@compiler-errors
Copy link
Member

Cool. r=me when it's green.

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 14, 2022

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Oct 14, 2022

📌 Commit 062ea9c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 15, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 15, 2022
@Dylan-DPC
Rollup merge of rust-lang#103003 - TaKO8Ki:fix-102989, r=compiler-errors
de5e4e8 
Fix `suggest_floating_point_literal` ICE

Fixes rust-lang#102989
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 15, 2022
@Dylan-DPC
Rollup merge of rust-lang#103003 - TaKO8Ki:fix-102989, r=compiler-errors
a75085f 
Fix `suggest_floating_point_literal` ICE

Fixes rust-lang#102989
This was referenced Oct 15, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2022
@bors
Auto merge of rust-lang#103083 - Dylan-DPC:rollup-97cvwdv, r=Dylan-DPC
c93ef33 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#102773 (Use semaphores for thread parking on Apple platforms)
 - rust-lang#102884 (resolve: Some cleanup, asserts and tests for lifetime ribs)
 - rust-lang#102954 (Add missing checks for `doc(cfg_hide(...))`)
 - rust-lang#102998 (Drop temporaries created in a condition, even if it's a let chain)
 - rust-lang#103003 (Fix `suggest_floating_point_literal` ICE)
 - rust-lang#103041 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 65dca11 into rust-lang:master Oct 15, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 15, 2022
@TaKO8Ki TaKO8Ki deleted the fix-102989 branch October 15, 2022 13:31
@Alexendoo Alexendoo mentioned this pull request Oct 16, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@eholk eholk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

ICE: index out of bounds: the len is 1 but the index is 1 -Cinstrument-coverage
8 participants
@TaKO8Ki @rust-highfive @rust-log-analyzer @compiler-errors @bors @matthiaskrgr @eholk @rustbot