-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Improve docs for struct_lint_level
function.
#102953
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improve docs for struct_lint_level
function.
#102953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment looks good, thanks! I left some suggestions.
There are a bunch of other functions also talking such a closure though. If I am calling tcx.struct_span_lint_hir
I will still be confused. Could you add a comment to all of them just briefly stating that the return value is ignored and pointing to struct_lint_level
?
Co-authored-by: Ralf Jung <post@ralfj.de>
I've applied the suggestions from review, this can be reviewed again. |
Looks good, thanks a lot! |
…ate_param, r=RalfJung Improve docs for `struct_lint_level` function. r? `@RalfJung` Does this answer your questions?
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#102857 (Add a regression test for rust-lang#39137) - rust-lang#102953 (Improve docs for `struct_lint_level` function.) - rust-lang#103060 (rustdoc: make the help button a link to a page) - rust-lang#103115 (Clean up anchors.goml rustdoc GUI test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
r? @RalfJung
Does this answer your questions?