Skip to content

Improve docs for struct_lint_level function. #102953

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Oct 16, 2022

Conversation

WaffleLapkin
Copy link
Member

r? @RalfJung

Does this answer your questions?

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 12, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2022
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment looks good, thanks! I left some suggestions.

There are a bunch of other functions also talking such a closure though. If I am calling tcx.struct_span_lint_hir I will still be confused. Could you add a comment to all of them just briefly stating that the return value is ignored and pointing to struct_lint_level?

@WaffleLapkin
Copy link
Member Author

I've applied the suggestions from review, this can be reviewed again.

@RalfJung
Copy link
Member

Looks good, thanks a lot!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 16, 2022

📌 Commit 39375e1 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2022
…ate_param, r=RalfJung

Improve docs for `struct_lint_level` function.

r? `@RalfJung`

Does this answer your questions?
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 16, 2022
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#102857 (Add a regression test for rust-lang#39137)
 - rust-lang#102953 (Improve docs for `struct_lint_level` function.)
 - rust-lang#103060 (rustdoc: make the help button a link to a page)
 - rust-lang#103115 (Clean up anchors.goml rustdoc GUI test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d6506cc into rust-lang:master Oct 16, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 16, 2022
@WaffleLapkin WaffleLapkin deleted the better_docs_for_decorate_param branch October 17, 2022 12:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants