Skip to content

Rollup of 4 pull requests #103119

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 16, 2022
Merged

Rollup of 4 pull requests #103119

merged 15 commits into from
Oct 16, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

saethlin and others added 15 commits October 9, 2022 15:18
@saethlin
Add a regression test for rust-lang#39137
bfd5bfe
@WaffleLapkin
Improve docs for struct_lint_level function.
f1ac7b5
@WaffleLapkin @RalfJung
Apply suggestions from code review
b1c3e78 
Co-authored-by: Ralf Jung <post@ralfj.de>
@WaffleLapkin
link lint function with decorate function param to struct_lint_level
c5de3ec
@notriddle
rustdoc: make the help button a link to a page
ae4ad9a 
This allows you to open the help section in a new browser tab, which is a
pretty reasonable thing to want for a documentation page.
@notriddle
rustdoc: fix Ctrl-Click on help and settings links
6f59981
@notriddle
rustdoc: add test cases for links inside the help popover
65f501e
@notriddle
rustdoc: make help button a no-op when on help page
8344481
@GuillaumeGomez
Update browser-ui-test version to 0.12.5
29e6b2d
@GuillaumeGomez
Clean up anchors.goml rustdoc GUI test
e77e5f3
@RalfJung
fix typo
39375e1
@matthiaskrgr
Rollup merge of rust-lang#102857 - saethlin:derived-enum-hash-test, r…
91c7d02 
…=Mark-Simulacrum

Add a regression test for rust-lang#39137

The problem in the issue has been fixed in the meantime, so since this adds a regression test I think this closes rust-lang#39137
@matthiaskrgr
Rollup merge of rust-lang#102953 - WaffleLapkin:better_docs_for_decor…
d6506cc 
…ate_param, r=RalfJung

Improve docs for `struct_lint_level` function.

r? ``@RalfJung``

Does this answer your questions?
@matthiaskrgr
Rollup merge of rust-lang#103060 - notriddle:notridddle/help-page, r=…
0bd24c5 
…GuillaumeGomez

rustdoc: make the help button a link to a page

This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page.

Preview: http://notriddle.com/notriddle-rustdoc-demos/help-page/std/index.html
@matthiaskrgr
Rollup merge of rust-lang#103115 - GuillaumeGomez:clean-up-anchors-gu…
ae717c7 
…i-test, r=notriddle

Clean up anchors.goml rustdoc GUI test

r? ``@notriddle``
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 16, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Oct 16, 2022

📌 Commit ae717c7 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 16, 2022
@bors
Copy link
Collaborator

bors commented Oct 16, 2022

⌛ Testing commit ae717c7 with merge bf286a8...

@bors
Copy link
Collaborator

bors commented Oct 16, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing bf286a8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 16, 2022
@bors bors merged commit bf286a8 into rust-lang:master Oct 16, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 16, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#103115 9b71b16dd3c1a2779bfe7f8947977b960c815a8d
#103060 1f84454d332d9ce35d96b6ba5468ac332cbba3dc
#102953 7837a1a1f5746b50cbfce25322b6515956d4c053
#102857 c9ca55ae096171d8528fc57fd26a33ca0eff02c1

previous master: 8be3ce9056

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bf286a8): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.5% [0.5%, 0.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 4.6% [4.4%, 4.7%] 4
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -9.0% [-18.0%, -2.4%] 21
Improvements ✅
(secondary)		 -3.6% [-4.0%, -3.1%] 2
All ❌✅ (primary) -6.8% [-18.0%, 4.7%] 25

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.3% [1.2%, 3.3%] 43
Regressions ❌
(secondary)		 2.9% [2.1%, 3.7%] 23
Improvements ✅
(primary)		 -14.9% [-29.0%, -2.0%] 43
Improvements ✅
(secondary)		 -8.8% [-12.4%, -4.2%] 12
All ❌✅ (primary) -6.3% [-29.0%, 3.3%] 86

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@Mark-Simulacrum
Copy link
Member

Memory usage improvement seems driven by rust-lang/rustc-perf#1450 (comment) -- maybe less parallelism so less memory?

@matthiaskrgr matthiaskrgr deleted the rollup-2vb8hif branch December 22, 2022 10:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
10 participants
@matthiaskrgr @bors @rust-timer @Mark-Simulacrum @rustbot @saethlin @WaffleLapkin @notriddle @GuillaumeGomez @RalfJung