-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Add fmt::Write to io::Write adapter #104389
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
@rustbot label +T-libs-api -T-libs |
This comment has been minimized.
This comment has been minimized.
This needs an ACP |
e75efbd
to
f5f6de6
Compare
Re-adding waiting-on-ACP since I can't do anything with it and it's in my review queue otherwise. |
☔ The latest upstream changes (presumably #110648) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot ready. The ACP and this PR should be ready now. |
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
…ss construction) Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
I just put out a similar proposal for |
I no longer think this is the appropriate implementation, though I still want composability between writeable traits. In the meantime, I've created this crate which generalizes over adapters, requiring only a single import: https://docs.rs/io-adapters/latest |
Closes #77733
ACP: rust-lang/libs-team#133