Rollup of 5 pull requests #110648
Merged
Rollup of 5 pull requests #110648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of places were using `replace(…, &mut [])`, but that can just be `take`.
instead of merging everything into a single bag. If it's acceptable from performance point of view, then it's more clear to keep this stuff organized more in accordance with its use.
…errors rustc_metadata: Split `children` into multiple tables instead of merging everything into a single bag. If it's acceptable from performance point of view, then it's more clear to keep this stuff organized more in accordance with its use.
…petrochenkov rustdoc: fix ICE from rustc_resolve and librustdoc parse divergence Fixes rust-lang#110495
…omcc Specialize some `io::Read` and `io::Write` methods for `VecDeque<u8>` and `&[u8]` This improves implementation of: - `<&[u8]>::read_to_string` - `VecDeque<u8>::read_to_end` - `VecDeque<u8>::read_to_string` - `VecDeque<u8>::write_vectored`
…g, r=lcnr Panic instead of truncating if the incremental on-disk cache is too big It seems _unlikely_ that anyone would hit this truncation, but if this `as` does actually truncate, that seems incredibly bad.
More `mem::take` in `library` A bunch of places were using `replace(…, &mut [])`, but that can just be `take`.
rustbot
added
A-query-system
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: fa4cc63a6b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 21, 2023
|
Finished benchmarking commit (fec9adc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
childreninto multiple tables #110333 (rustc_metadata: Splitchildreninto multiple tables)io::Readandio::Writemethods forVecDeque<u8>and&[u8]#110608 (Specialize someio::Readandio::Writemethods forVecDeque<u8>and&[u8])mem::takeinlibrary#110633 (Moremem::takeinlibrary)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup