Skip to content

Fix using include_bytes in pattern position #104416

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Conversation

clubby789
Copy link
Contributor

Fix #104414

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2022
Co-authored-by: Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>
@eholk
Copy link
Contributor

eholk commented Nov 21, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 21, 2022

📌 Commit 3652b89 has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2022
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#103396 (Pin::new_unchecked: discuss pinning closure captures)
 - rust-lang#104416 (Fix using `include_bytes` in pattern position)
 - rust-lang#104557 (Add a test case for async dyn* traits)
 - rust-lang#104559 (Split `MacArgs` in two.)
 - rust-lang#104597 (Probe + better error messsage for `need_migrate_deref_output_trait_object`)
 - rust-lang#104656 (Move tests)
 - rust-lang#104657 (Do not check transmute if has non region infer)
 - rust-lang#104663 (rustdoc: factor out common button CSS)
 - rust-lang#104666 (Migrate alias search result to CSS variables)
 - rust-lang#104674 (Make negative_impl and negative_impl_exists take the right types)
 - rust-lang#104692 (Update test's cfg-if dependency to 1.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a3eca6 into rust-lang:master Nov 22, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 22, 2022
zydou pushed a commit to zydou/arti that referenced this pull request Nov 24, 2022
Now that they have merged
rust-lang/rust#104416 ,
our CI should pass again with the regular nightly image.

Rather than remove the pinned image entirely, I'm commenting it out,
with a comment explaining how to pin an image the next time we need
to do so.

Closes #633.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 1, 2022
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#103396 (Pin::new_unchecked: discuss pinning closure captures)
 - rust-lang#104416 (Fix using `include_bytes` in pattern position)
 - rust-lang#104557 (Add a test case for async dyn* traits)
 - rust-lang#104559 (Split `MacArgs` in two.)
 - rust-lang#104597 (Probe + better error messsage for `need_migrate_deref_output_trait_object`)
 - rust-lang#104656 (Move tests)
 - rust-lang#104657 (Do not check transmute if has non region infer)
 - rust-lang#104663 (rustdoc: factor out common button CSS)
 - rust-lang#104666 (Migrate alias search result to CSS variables)
 - rust-lang#104674 (Make negative_impl and negative_impl_exists take the right types)
 - rust-lang#104692 (Update test's cfg-if dependency to 1.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@clubby789 clubby789 deleted the fix-104414 branch February 11, 2023 14:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-pattern macro in pattern position: include_bytes
5 participants