Add a test case for async dyn* traits #104557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler/rustc_trait_selection/src/traits/select/confirmation.rs
Outdated
Show resolved
Hide resolved
|
For the record, this is alternatively fixed via #103386. |
Sounds good. Let's go with that fix then. I think it's still worth keeping this test case around since the goal of |
eholk
force-pushed
the
dyn-star-in-traits
branch
from
8ce1597 to
f807d37
Compare
This comment has been minimized.
This comment has been minimized.
eholk
changed the title
|
r=me after rebasing |
compiler-errors
added
S-waiting-on-author
eholk
force-pushed
the
dyn-star-in-traits
branch
from
f807d37 to
ff38c35
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#103396 (Pin::new_unchecked: discuss pinning closure captures) - rust-lang#104416 (Fix using `include_bytes` in pattern position) - rust-lang#104557 (Add a test case for async dyn* traits) - rust-lang#104559 (Split `MacArgs` in two.) - rust-lang#104597 (Probe + better error messsage for `need_migrate_deref_output_trait_object`) - rust-lang#104656 (Move tests) - rust-lang#104657 (Do not check transmute if has non region infer) - rust-lang#104663 (rustdoc: factor out common button CSS) - rust-lang#104666 (Migrate alias search result to CSS variables) - rust-lang#104674 (Make negative_impl and negative_impl_exists take the right types) - rust-lang#104692 (Update test's cfg-if dependency to 1.0) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 1, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#103396 (Pin::new_unchecked: discuss pinning closure captures) - rust-lang#104416 (Fix using `include_bytes` in pattern position) - rust-lang#104557 (Add a test case for async dyn* traits) - rust-lang#104559 (Split `MacArgs` in two.) - rust-lang#104597 (Probe + better error messsage for `need_migrate_deref_output_trait_object`) - rust-lang#104656 (Move tests) - rust-lang#104657 (Do not check transmute if has non region infer) - rust-lang#104663 (rustdoc: factor out common button CSS) - rust-lang#104666 (Migrate alias search result to CSS variables) - rust-lang#104674 (Make negative_impl and negative_impl_exists take the right types) - rust-lang#104692 (Update test's cfg-if dependency to 1.0) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case that approximates async functions in dyn traits using
dyn*. The purpose is to have an example of where we are withdyn*and the goal of using it for dyn traits.Issue #102425
r? @compiler-errors