Add comment to cleanup_kinds #105194
Merged
Add comment to cleanup_kinds #105194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
davidtwco
requested changes
Jan 7, 2023
based on the original commit message 1ae7ae0
tmiasko
force-pushed
the
cleanup-kinds
branch
from
f0697e8 to
836ef61
Compare
|
@bors r=davidtwco rollup=always |
This comment was marked as resolved.
This comment was marked as resolved.
bors
added
S-waiting-on-bors
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks spurious so will re-approve. @bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2023
Rollup of 14 pull requests Successful merges: - rust-lang#105194 (Add comment to cleanup_kinds) - rust-lang#106521 (remove E0280) - rust-lang#106628 (Remove unneeded ItemId::Primitive variant) - rust-lang#106635 (std sync tests: better type name, clarifying comment) - rust-lang#106642 (Add test for rust-lang#106062) - rust-lang#106645 ([RFC 2397] Initial implementation) - rust-lang#106653 (Fix help docs for -Zallow-features) - rust-lang#106657 (Remove myself from rust-lang/rust reviewers) - rust-lang#106662 (specialize impl of `ToString` on `bool`) - rust-lang#106669 (create helper function for `rustc_lint_defs::Level` and remove it's duplicated code) - rust-lang#106671 (Change flags with a fixed default value from Option<bool> to bool) - rust-lang#106689 (Fix invalid files array re-creation in rustdoc-gui tester) - rust-lang#106690 (Fix scrolling for item declaration block) - rust-lang#106698 (Add compiler-errors to some trait system notification groups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the original commit message 1ae7ae0