specialize impl of ToString on bool
#106662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
@bors r+ rollup |
|
🌲 The tree is currently closed for pull requests below priority 999. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2023
Rollup of 14 pull requests Successful merges: - rust-lang#105194 (Add comment to cleanup_kinds) - rust-lang#106521 (remove E0280) - rust-lang#106628 (Remove unneeded ItemId::Primitive variant) - rust-lang#106635 (std sync tests: better type name, clarifying comment) - rust-lang#106642 (Add test for rust-lang#106062) - rust-lang#106645 ([RFC 2397] Initial implementation) - rust-lang#106653 (Fix help docs for -Zallow-features) - rust-lang#106657 (Remove myself from rust-lang/rust reviewers) - rust-lang#106662 (specialize impl of `ToString` on `bool`) - rust-lang#106669 (create helper function for `rustc_lint_defs::Level` and remove it's duplicated code) - rust-lang#106671 (Change flags with a fixed default value from Option<bool> to bool) - rust-lang#106689 (Fix invalid files array re-creation in rustdoc-gui tester) - rust-lang#106690 (Fix scrolling for item declaration block) - rust-lang#106698 (Add compiler-errors to some trait system notification groups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106611
Specialize
boolsToStringimpl by copying it fromDisplay. This is a significant optimization as we avoid lots of dynamic dispatch. AFAIK, this doesn't require a API Change Proposal as this doesn't regress existing code and can be undone without regressing code.