Skip to content

Don't ICE in closure arg borrow suggestion #105882

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2022
Merged

Don't ICE in closure arg borrow suggestion #105882

merged 1 commit into from
Dec 19, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #105832

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2022

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2022
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 18, 2022

📌 Commit dd8897e has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Dec 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2022
@bors
Auto merge of rust-lang#105892 - Dylan-DPC:rollup-eozolx4, r=Dylan-DPC
4653c93 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#105682 (Use `expose_addr()` in `fmt::Pointer`)
 - rust-lang#105839 (Suggest a `T: Send` bound for `&mut T` upvars in `Send` generators)
 - rust-lang#105864 (clippy::complexity fixes)
 - rust-lang#105882 (Don't ICE in closure arg borrow suggestion)
 - rust-lang#105889 (Fix `uninlined_format_args` in libtest)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3350ae9 into rust-lang:master Dec 19, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 19, 2022
@compiler-errors compiler-errors deleted the issue-105832 branch August 11, 2023 20:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

found node must be a function/thread 'rustc' panicked at 'Box<dyn Any>' when using nom parser
4 participants
@compiler-errors @rustbot @jackh726 @bors