Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

llvm-wrapper: adapt for LLVM API change #106113

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

krasimirgg
Copy link
Contributor

No functional changes intended.

The LLVM commit llvm/llvm-project@e6b0221 added TargetExtTyID to the TypeID enum. This adapts RustWrapper accordingly.

@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2022

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 24, 2022
@krasimirgg
Copy link
Contributor Author

@rustbot label: +llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Dec 24, 2022
@nikic
Copy link
Contributor

nikic commented Dec 24, 2022

Hm, I wonder if we shouldn't just add a default? If LLVM adds a new type, we're generally not going to care about until we start emitting it, and support can be added at that time.

@krasimirgg
Copy link
Contributor Author

r? @nikic

@rustbot rustbot assigned nikic and unassigned cuviper Jan 2, 2023
@krasimirgg
Copy link
Contributor Author

Hm, I wonder if we shouldn't just add a default? If LLVM adds a new type, we're generally not going to care about until we start emitting it, and support can be added at that time.

done

@krasimirgg krasimirgg marked this pull request as ready for review January 2, 2023 13:54
No functional changes intended.

The LLVM commit llvm/llvm-project@e6b0221 added `TargetExtTyID` to the `TypeID` enum. This adapts `RustWrapper` accordingly.
@nikic
Copy link
Contributor

nikic commented Jan 21, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 21, 2023

📌 Commit 799fa60 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 21, 2023
llvm-wrapper: adapt for LLVM API change

No functional changes intended.

The LLVM commit llvm/llvm-project@e6b0221 added `TargetExtTyID` to the `TypeID` enum. This adapts `RustWrapper` accordingly.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 22, 2023
llvm-wrapper: adapt for LLVM API change

No functional changes intended.

The LLVM commit llvm/llvm-project@e6b0221 added `TargetExtTyID` to the `TypeID` enum. This adapts `RustWrapper` accordingly.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2023
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#103418 (Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report)
 - rust-lang#106113 (llvm-wrapper: adapt for LLVM API change)
 - rust-lang#106144 (Improve the documentation of `black_box`)
 - rust-lang#106578 (Label closure captures/generator locals that make opaque types recursive)
 - rust-lang#106749 (Update cc to 1.0.77)
 - rust-lang#106935 (Fix `SingleUseLifetime` ICE)
 - rust-lang#107015 (Re-enable building rust-analyzer on riscv64)
 - rust-lang#107029 (Add new bootstrap members to triagebot.toml)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2504c8d into rust-lang:master Jan 22, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants