Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rollup of 8 pull requests #107185

Merged
merged 16 commits into from
Jan 22, 2023
Merged

Rollup of 8 pull requests #107185

merged 16 commits into from
Jan 22, 2023

Conversation

compiler-errors
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

krasimirgg and others added 16 commits January 2, 2023 14:31
No functional changes intended.

The LLVM commit llvm/llvm-project@e6b0221 added `TargetExtTyID` to the `TypeID` enum. This adapts `RustWrapper` accordingly.
Fixes (without a test) rust-lang#98746.
It was disabled in rust-lang#75103 due to an LLVM bug, but followup comments have
confirmed that it builds fine on Fedora with LLVM 15.
…ncompat, r=davidtwco

Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report

See rust-lang#79813 for a discussion of this lint. This has been warn-by-default for over a year, so adding it to the future-incompat report should help to find libraries that haven't yet updated.
llvm-wrapper: adapt for LLVM API change

No functional changes intended.

The LLVM commit llvm/llvm-project@e6b0221 added `TargetExtTyID` to the `TypeID` enum. This adapts `RustWrapper` accordingly.
Improve the documentation of `black_box`

There don't seem to be many great resources on how `black_box` should be used, so I added some information here
…losure, r=TaKO8Ki

Label closure captures/generator locals that make opaque types recursive

cc rust-lang#46415 (comment)
Fix `SingleUseLifetime` ICE

Fixes rust-lang#104440
cc: ``@matthiaskrgr``
Re-enable building rust-analyzer on riscv64

It was disabled in rust-lang#75103 due to an LLVM bug, but followup comments have
confirmed that it builds fine on Fedora with LLVM 15.

r? ```@Mark-Simulacrum```
cc ```@matklad``` ```@davidlt```
…ulacrum

Add new bootstrap members to triagebot.toml

```@ozkanonur``` if you want to be assigned to review PRs too, just post a message to this thread.

Should a `T-bootstrap` label be created, since `src/tools/tidy` is assigned to the `bootstrap` members, but labeled `A-testsuite` (and not `A-bootstrap`) ?

cc ```@jyn514```
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 22, 2023
@compiler-errors
Copy link
Member Author

@bors r+ rollup=never p=8

@bors
Copy link
Collaborator

bors commented Jan 22, 2023

📌 Commit 31f9f21 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2023
@bors
Copy link
Collaborator

bors commented Jan 22, 2023

⌛ Testing commit 31f9f21 with merge 940d00f...

@bors
Copy link
Collaborator

bors commented Jan 22, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 940d00f to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Jan 22, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 940d00f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 22, 2023
@bors bors merged commit 940d00f into rust-lang:master Jan 22, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha

previous master: 940d00f2f6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

1 similar comment
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha

previous master: 940d00f2f6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rustbot rustbot added this to the 1.68.0 milestone Jan 22, 2023
@rust-timer
Copy link
Collaborator

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (940d00f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.6% [2.2%, 5.0%] 2
Regressions ❌
(secondary)
7.9% [7.9%, 7.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) 3.6% [2.2%, 5.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@compiler-errors compiler-errors deleted the rollup-wkomjma branch August 11, 2023 20:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.