-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix use suggestion span #106962
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix use suggestion span #106962
Conversation
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Is there a test for the |
@workingjubilee that was fixed in #106175, but it's not currently a structured/apply-able suggestion due to the spans not being tracked correctly. |
On nightly:
|
1ceb812
to
12bdb05
Compare
This comment has been minimized.
This comment has been minimized.
12bdb05
to
2172577
Compare
No problem, just thought I'd ask, as I had been fiddling around with a few cases of this. |
@bors r+ rollup |
Rollup of 5 pull requests Successful merges: - rust-lang#101698 (Constify `TypeId` ordering impls) - rust-lang#106148 (Fix unused_parens issue for higher ranked function pointers) - rust-lang#106922 (Avoid unsafe code in `to_ascii_[lower/upper]case()`) - rust-lang#106951 (Remove ineffective run of SimplifyConstCondition) - rust-lang#106962 (Fix use suggestion span) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #106954