Rollup of 5 pull requests #106984
Merged
Rollup of 5 pull requests #106984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no constant conditions at this stage.
…=scottmcm Constify `TypeId` ordering impls Tracking issue: rust-lang#101871 Adding const ordering to `TypeId` allows rtti crates to optimize some casting scenarios (without transmuting to `u64`). This would also prevent these crates from breaking if the underlying type is changed from `u64` to something different. Feature gate: `#![feature(const_cmp_type_id)]`
…d, r=lcnr Fix unused_parens issue for higher ranked function pointers fixes rust-lang#105061 r? `@lcnr`
…jubilee Avoid unsafe code in `to_ascii_[lower/upper]case()`
…-obk Remove ineffective run of SimplifyConstCondition There are no constant conditions at this stage.
…li-obk Fix use suggestion span Fixes rust-lang#106954
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: f34cc658eb In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (38a76f3): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TypeIdordering impls #101698 (ConstifyTypeIdordering impls)to_ascii_[lower/upper]case()#106922 (Avoid unsafe code into_ascii_[lower/upper]case())Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup