Erase regions before doing uninhabited check in borrowck #107532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-query-system
|
A little bit more background here, on the problem and the fix, would be helpful. I can understand why it's okay to do this, but not why it's needed. |
Not sure exactly whether you're looking for:
Does that make sense? I can go into more detail if you'd like. |
|
Right, I'm more curious why we have unresolved inference variables? r=me, but a comment would be nice |
|
Oh, it's unresolved region vids, cause it's MIR borrowck and we haven't yet done the region solving yet 😆 I'll leave a comment |
|
Gonna drop bbf3383 from this, since that's blocked on some rustdoc + const eval bug :/ I'm still gonna land the real fix for the issue, though. |
compiler-errors
force-pushed
the
erase-regions-in-uninhabited
branch
from
24a97e2 to
2c23c7f
Compare
|
@bors r=jackh726 |
|
🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 2, 2023
…ninhabited, r=jackh726 Erase regions before doing uninhabited check in borrowck ~Also, fingerprint query keys/values when debug assertions are enabled. This should make it easier to check for issues like this without `-Cincremental`, and make UI tests a bit cleaner.~ edit: moving that to a separate PR Fixes rust-lang#107505
This was referenced Feb 2, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 2, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106919 (Recover `_` as `..` in field pattern) - rust-lang#107493 (Improve diagnostic for missing space in range pattern) - rust-lang#107515 (Improve pretty-printing of `HirIdValidator` errors) - rust-lang#107524 (Remove both StorageLive and StorageDead in CopyProp.) - rust-lang#107532 (Erase regions before doing uninhabited check in borrowck) - rust-lang#107559 (Rename `rust_2015` → `is_rust_2015`) - rust-lang#107577 (Reinstate the `hir-stats.rs` tests on stage 1.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fingerprint query keys/values when debug assertions are enabled. This should make it easier to check for issues like this withoutedit: moving that to a separate PR-Cincremental, and make UI tests a bit cleaner.Fixes #107505