Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
eggyal
reviewed
Feb 1, 2023
| @@ -702,7 +702,7 @@ impl<'a> Parser<'a> { | |||
| /// Is a `dyn B0 + ... + Bn` type allowed here? | |||
| fn is_explicit_dyn_type(&mut self) -> bool { | |||
| self.check_keyword(kw::Dyn) | |||
| && (!self.token.uninterpolated_span().rust_2015() | |||
| && (self.token.uninterpolated_span().rust_2018() | |||
There was a problem hiding this comment.
Wouldn't it make sense for this similarly to be renamed is_rust_2018, and so on for all such edition tests?
There was a problem hiding this comment.
No, see the linked comment. rust_2015 is == 2015, but rust_2018 is >= 2018 (similarly for others).
davidtwco
approved these changes
Feb 1, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7f8bf60 with merge 719b6328260db2e1f22b3541221bd6dac45f47db... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Hmm... I think bors is busted. I'll post about it on T-infra (https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Every.20rust-lang.2Frust.20PR.20is.20failing.20bors) @bors treeclosed=50 |
|
@bors retry CI was broken |
bors
added
S-waiting-on-bors
This was referenced Feb 1, 2023
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 2, 2023
Rename `rust_2015` → `is_rust_2015` r? `@compiler-errors` rust-lang#107508 (comment)
|
☔ The latest upstream changes (presumably #105670) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
is_it_2015¿
branch
from
7f8bf60 to
a7f97a7
Compare
|
@bors r=davidtwco |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 2, 2023
Rename `rust_2015` → `is_rust_2015` r? `@compiler-errors` rust-lang#107508 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 2, 2023
Rename `rust_2015` → `is_rust_2015` r? ``@compiler-errors`` rust-lang#107508 (comment)
This was referenced Feb 2, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 2, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106919 (Recover `_` as `..` in field pattern) - rust-lang#107493 (Improve diagnostic for missing space in range pattern) - rust-lang#107515 (Improve pretty-printing of `HirIdValidator` errors) - rust-lang#107524 (Remove both StorageLive and StorageDead in CopyProp.) - rust-lang#107532 (Erase regions before doing uninhabited check in borrowck) - rust-lang#107559 (Rename `rust_2015` → `is_rust_2015`) - rust-lang#107577 (Reinstate the `hir-stats.rs` tests on stage 1.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This comment has been minimized.
This comment has been minimized.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @compiler-errors
#107508 (comment)