Add new people to the compiletest review rotation #108125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
wesleywiser
approved these changes
Feb 16, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
| @@ -630,7 +630,7 @@ style-team = [ | |||
| "/src/stage0.json" = ["bootstrap"] | |||
| "/tests/ui" = ["compiler"] | |||
| "/src/tools/cargo" = ["@ehuss", "@joshtriplett"] | |||
| "/src/tools/compiletest" = ["bootstrap"] | |||
| "/src/tools/compiletest" = ["bootstrap", "@wesleywiser", "@oli-obk"] | |||
There was a problem hiding this comment.
I was asleep when this PR was put up, but I can also add myself to this rotation since I have reasonable familiarity with compiletest :)
There was a problem hiding this comment.
Go ahead, more is better!
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106347 (More accurate spans for arg removal suggestion) - rust-lang#108057 (Prevent some attributes from being merged with others on reexports) - rust-lang#108090 (`if $c:expr { Some($r:expr) } else { None }` =>> `$c.then(|| $r)`) - rust-lang#108092 (note issue for feature(packed_bundled_libs)) - rust-lang#108099 (use chars instead of strings where applicable) - rust-lang#108115 (Do not ICE on unmet trait alias bounds) - rust-lang#108125 (Add new people to the compiletest review rotation) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oli-obk and @wesleywiser volunteered to be part of the review rotation of compiletest in https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202023-02-16/near/328274017