Skip to content

Rollup of 7 pull requests #108127

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 24 commits into from
Feb 16, 2023
Merged

Rollup of 7 pull requests #108127

merged 24 commits into from
Feb 16, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GuillaumeGomez and others added 24 commits February 14, 2023 18:42
…O8Ki

More accurate spans for arg removal suggestion

Partially address rust-lang#106304.
…erge, r=notriddle

Prevent some attributes from being merged with others on reexports

Final fix for rust-lang#59368.

As discussed on zulip [here](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Filtering.20sub.20attributes.20in.20ast.3A.3AAttribute), we need to clone the `Attribute` to be able to filter some parts of it. Then we need to go through the attributes to able to only keep what we want (everything except a few attributes in short).

As for the second commit, when I wrote the test, I realized that the code to traverse all reexports one by one to collect all their attributes was not completely working so I fixed the few issues remaining.

r? `@notriddle`
…, r=oli-obk

`if $c:expr { Some($r:expr) } else { None }` =>> `$c.then(|| $r)`

Resurrection of rust-lang#108079
…l, r=petrochenkov

note issue for feature(packed_bundled_libs)

Add to feature (introduced in rust-lang#105601) gate description number of issue created for it.

r? `@petrochenkov`
…umeGomez

use chars instead of strings where applicable
…compiler-errors

Do not ICE on unmet trait alias bounds

Rework of rust-lang#108093 following feedback on that PR.

Fixes rust-lang#108072

r? `@compiler-errors`
…viewers, r=wesleywiser

Add new people to the compiletest review rotation

`@oli-obk` and `@wesleywiser` volunteered to be part of the review rotation of compiletest in https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202023-02-16/near/328274017
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 16, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Feb 16, 2023

📌 Commit eb9f9c7 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2023
@bors
Copy link
Collaborator

bors commented Feb 16, 2023

⌛ Testing commit eb9f9c7 with merge 9a7cc6c...

@bors
Copy link
Collaborator

bors commented Feb 16, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9a7cc6c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2023
@bors bors merged commit 9a7cc6c into rust-lang:master Feb 16, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 16, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#108125 f4a9458a69d8009569ec9ad2121785b480af7eae
#108115 44de64e143d35822de1778f553683cdd84d2e40e
#108099 65c019942fb07564443fcaed03faa4309d8474aa
#108092 990de89ab9ee4986064815d6bc4f7d01c5455a17
#108090 93b0424647d0a51641a82aca00b7cfb084ce33f7
#108057 47a1e7e7b2c5653bd8a8ae9193fc2a712d52d4d1
#106347 5b1f3aa06b2a85b100ac906d29ae1fd3d0bdf79b

previous master: c5d1b3ea96

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9a7cc6c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.4% [1.4%, 3.5%] 2
Regressions ❌
(secondary)
2.2% [0.9%, 3.1%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.4% [1.4%, 3.5%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants