Rollup of 6 pull requests #110275
Merged
Rollup of 6 pull requests #110275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- require `TypeErrCtxt` to always result in an error - move `resolve_regions_and_report_errors` to the `ObligationCtxt` - merge `process_registered_region_obligations` into `resolve_regions`
Typo in the documentation.
It's what all the call sites require.
It's weird and unnecessary.
It is only implemented for `Region`, where it is equivalent to the inherent `as_var` method.
I'm surprised the compiler doesn't warn about these. It appears having an `impl` on a struct is enough to avoid a warning about it never being constructed.
…, r=Mark-Simulacrum Stabilize IsTerminal FCP completed in rust-lang#98070 . closes: rust-lang#98070
…iemjay Erase lifetimes above `ty::INNERMOST` when probing ambiguous types Turns out that `TyCtxt::replace_escaping_bound_vars_uncached` only erases bound vars exactly at `ty::INNERMOST`, and not everything above. This regresses the suggestions for non-lifetime binders, but oh well, I don't really care about those. Fixes rust-lang#110052
…iler-errors Remove `ToRegionVid` r? ```@compiler-errors```
cleanup our region error API - require `TypeErrCtxt` to always result in an error, closing rust-lang#108810 - move `resolve_regions_and_report_errors` to the `ObligationCtxt` - call `process_registered_region_obligations` in `resolve_regions` - move `resolve_regions` into the `outlives` submodule - add `#[must_use]` to functions returning lists of errors r? types
…=cuviper Fix btree `CursorMut::insert_after` check Fixes a check inside `BTreeMap`'s `CursorMut::insert_after`, where it would peek the previous element to check whether the inserted key is below the next one, instead of peeking the next element.
Update unwind_safe.rs Typo in the documentation.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=6 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: d37e2f74af In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 13, 2023
|
Finished benchmarking commit (fab9907): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ty::INNERMOSTwhen probing ambiguous types #110195 (Erase lifetimes abovety::INNERMOSTwhen probing ambiguous types)ToRegionVid#110218 (RemoveToRegionVid)CursorMut::insert_aftercheck #110234 (Fix btreeCursorMut::insert_aftercheck)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup