-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Various minor Idx-related tweaks #110394
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Various minor Idx-related tweaks #110394
Conversation
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
Nothing particularly exciting here, but a couple of things I noticed as I was looking for more index conversions to simplify.
use rustc_index::vec::{Idx, IndexSlice, IndexVec}; | ||
use rustc_index::vec::{IndexSlice, IndexVec}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh? How did this not issue dead code lint before? O_o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layout.rs
file has use super::*;
rather than doing its own imports. So it's the change in the other file that lets this be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
@bors r+ rollup |
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104055 (Migrate diagnostics in `rustc_borrowck`) - rust-lang#110257 (fix false positives for `unused_parens` around unary and binary operations) - rust-lang#110313 (allow `repr(align = x)` on inherent methods) - rust-lang#110337 (Correct default value for default-linker-libraries) - rust-lang#110386 (Clean up traversal macros) - rust-lang#110394 (Various minor Idx-related tweaks) - rust-lang#110425 (Encode def span for `ConstParam`) - rust-lang#110434 (Check freeze with right param-env in `deduced_param_attrs`) - rust-lang#110455 (tests: adapt for LLVM change 5b386b8) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Nothing particularly exciting here, but a couple of things I noticed as I was looking for more index conversions to simplify.
cc rust-lang/compiler-team#606
r? @WaffleLapkin