Various minor Idx-related tweaks #110394
Merged
Various minor Idx-related tweaks #110394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
rustbot
added
A-query-system
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
Nothing particularly exciting here, but a couple of things I noticed as I was looking for more index conversions to simplify.
WaffleLapkin
approved these changes
Apr 17, 2023
| use rustc_index::vec::{Idx, IndexSlice, IndexVec}; | ||
| use rustc_index::vec::{IndexSlice, IndexVec}; |
There was a problem hiding this comment.
Huh? How did this not issue dead code lint before? O_o
There was a problem hiding this comment.
The layout.rs file has use super::*; rather than doing its own imports. So it's the change in the other file that lets this be removed.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104055 (Migrate diagnostics in `rustc_borrowck`) - rust-lang#110257 (fix false positives for `unused_parens` around unary and binary operations) - rust-lang#110313 (allow `repr(align = x)` on inherent methods) - rust-lang#110337 (Correct default value for default-linker-libraries) - rust-lang#110386 (Clean up traversal macros) - rust-lang#110394 (Various minor Idx-related tweaks) - rust-lang#110425 (Encode def span for `ConstParam`) - rust-lang#110434 (Check freeze with right param-env in `deduced_param_attrs`) - rust-lang#110455 (tests: adapt for LLVM change 5b386b8) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing particularly exciting here, but a couple of things I noticed as I was looking for more index conversions to simplify.
cc rust-lang/compiler-team#606
r? @WaffleLapkin